From 31964fd155e4be86eca18d8c72c9c1ffd4b42ae4 Mon Sep 17 00:00:00 2001 From: John Stiles Date: Tue, 5 May 2020 16:05:47 -0400 Subject: [PATCH] Qualify local constant strings with static, and remove unused strings. Change-Id: Icd317eb1b260e9640473e8a201a204a6e49bc002 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/287916 Auto-Submit: John Stiles Commit-Queue: Brian Osman Reviewed-by: Brian Osman --- tools/viewer/Viewer.cpp | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/tools/viewer/Viewer.cpp b/tools/viewer/Viewer.cpp index 11667798b9..ee5dbaf594 100644 --- a/tools/viewer/Viewer.cpp +++ b/tools/viewer/Viewer.cpp @@ -241,19 +241,17 @@ class NullSlide : public Slide { } }; -const char* kName = "name"; -const char* kValue = "value"; -const char* kOptions = "options"; -const char* kSlideStateName = "Slide"; -const char* kBackendStateName = "Backend"; -const char* kMSAAStateName = "MSAA"; -const char* kPathRendererStateName = "Path renderer"; -const char* kSoftkeyStateName = "Softkey"; -const char* kSoftkeyHint = "Please select a softkey"; -const char* kFpsStateName = "FPS"; -const char* kON = "ON"; -const char* kOFF = "OFF"; -const char* kRefreshStateName = "Refresh"; +static const char kName[] = "name"; +static const char kValue[] = "value"; +static const char kOptions[] = "options"; +static const char kSlideStateName[] = "Slide"; +static const char kBackendStateName[] = "Backend"; +static const char kMSAAStateName[] = "MSAA"; +static const char kPathRendererStateName[] = "Path renderer"; +static const char kSoftkeyStateName[] = "Softkey"; +static const char kSoftkeyHint[] = "Please select a softkey"; +static const char kON[] = "ON"; +static const char kRefreshStateName[] = "Refresh"; extern bool gUseSkVMBlitter; extern bool gSkVMJITViaDylib;