AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[infra] No task deduplication

Browse Source 
Isolates are expiring despite the tasks which generate them being
deduped. Hopefully this is temporary, and we can update the isolate
server to expire based on last usage date rather than creation date.

Change-Id: I7158612cd9b28c80268c54da9af88d2048e6aad1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226176
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This commit is contained in:
Eric Boren 2019-07-09 12:54:43 -04:00 committed by Skia Commit-Bot
parent b42af2f2cc
commit 326ad9e716
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
infra/bots/gen_tasks.go
View File

@ -699,8 +699,7 @@ func bundleRecipes(b *specs.TasksCfgBuilder) string {
EnvPrefixes: map[string][]string{
"PATH": []string{"cipd_bin_packages", "cipd_bin_packages/bin"},
},
Idempotent: true,
Isolate: relpath("recipes.isolate"),
Isolate: relpath("recipes.isolate"),
})
return BUNDLE_RECIPES_NAME
}
@ -718,8 +717,7 @@ func buildTaskDrivers(b *specs.TasksCfgBuilder) string {
EnvPrefixes: map[string][]string{
"PATH": {"cipd_bin_packages", "cipd_bin_packages/bin", "go/go/bin"},
},
Idempotent: true,
Isolate: "task_drivers.isolate",
Isolate: "task_drivers.isolate",
})
return BUILD_TASK_DRIVERS_NAME
}
@ -806,7 +804,6 @@ func isolateCIPDAsset(b *specs.TasksCfgBuilder, name string) string {
},
Command: []string{"/bin/cp", "-rL", asset.path, "${ISOLATED_OUTDIR}"},
Dimensions: linuxGceDimensions(MACHINE_TYPE_SMALL),
Idempotent: true,
Isolate: relpath("empty.isolate"),
})
return name

7
infra/bots/tasks.json
View File

@ -17287,7 +17287,6 @@
"go/go/bin"
]
},
"idempotent": true,
"isolate": "task_drivers.isolate"
},
"Housekeeper-PerCommit-BundleRecipes": {
@ -17331,7 +17330,6 @@
"cipd_bin_packages/bin"
]
},
"idempotent": true,
"isolate": "recipes.isolate"
},
"Housekeeper-PerCommit-CheckGeneratedFiles": {
@ -17647,7 +17645,6 @@
"os:Debian-9.8",
"pool:Skia"
],
"idempotent": true,
"isolate": "empty.isolate"
},
"Housekeeper-PerCommit-IsolateSKP": {
@ -17671,7 +17668,6 @@
"os:Debian-9.8",
"pool:Skia"
],
"idempotent": true,
"isolate": "empty.isolate"
},
"Housekeeper-PerCommit-IsolateSVG": {
@ -17695,7 +17691,6 @@
"os:Debian-9.8",
"pool:Skia"
],
"idempotent": true,
"isolate": "empty.isolate"
},
"Housekeeper-PerCommit-IsolateSkImage": {
@ -17719,7 +17714,6 @@
"os:Debian-9.8",
"pool:Skia"
],
"idempotent": true,
"isolate": "empty.isolate"
},
"Housekeeper-PerCommit-IsolateWinToolchain": {
@ -17743,7 +17737,6 @@
"os:Debian-9.8",
"pool:Skia"
],
"idempotent": true,
"isolate": "empty.isolate"
},
"Housekeeper-Weekly-RecreateSKPs": {