AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix a memory leak reported by clang static analyzer.

Browse Source 
The CFStringCreateWithCString method respect the "Create Rule" [1]
regarding the ownership of the returned reference. This means that
the object needs to be deallocated explicitly by calling CFRelease.

[1]: https://developer.apple.com/library/content/documentation/CoreFoundation/Conceptual/CFMemoryMgmt/Concepts/Ownership.html#//apple_ref/doc/uid/20001148-103029

BUG=648210
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354963002

Review-Url: https://codereview.chromium.org/2354963002
This commit is contained in:
sdefresne 2016-09-20 08:53:14 -07:00 committed by Commit bot
parent 73603f3c52
commit 388127f192
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/ports/SkOSFile_stdio.cpp
View File

@ -31,6 +31,7 @@ static FILE* ios_open_from_bundle(const char path[], const char* perm) {
// Get a reference to the file's URL // Get a reference to the file's URL
CFStringRef pathRef = CFStringCreateWithCString(NULL, path, kCFStringEncodingUTF8); CFStringRef pathRef = CFStringCreateWithCString(NULL, path, kCFStringEncodingUTF8);
CFURLRef imageURL = CFBundleCopyResourceURL(mainBundle, pathRef, NULL, NULL); CFURLRef imageURL = CFBundleCopyResourceURL(mainBundle, pathRef, NULL, NULL);
CFRelease(pathRef);
if (!imageURL) { if (!imageURL) {
return nullptr; return nullptr;
} }