Remove invalid from the list of opaque types.

This wasn't meaningful, and made some error reporting worse.

Change-Id: I5e72b5aca5d3e159b8439fa9809290d75e44cbe2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/472656
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>

src/sksl/ir/SkSLType.h

@@ -296,7 +296,6 @@ public:
         switch (fTypeKind) {
             case TypeKind::kBlender:
             case TypeKind::kColorFilter:
-            case TypeKind::kOther:
             case TypeKind::kSampler:
             case TypeKind::kSeparateSampler:
             case TypeKind::kShader:

tests/sksl/errors/ArrayOfVoid.glsl

@@ -3,7 +3,8 @@
 error: 3: type 'void' may not be used in an array
 error: 4: type 'void' may not be used in an array
 error: 6: type 'void' may not be used in an array
+error: 6: function 'funcF' can exit without returning a value
 error: 7: type 'void' may not be used in an array
 error: 8: type 'void' may not be used in an array
 error: 9: type 'void' may not be used in an array
-6 errors
+7 errors

tests/sksl/errors/AssignmentTypeMismatch.glsl

@@ -3,8 +3,8 @@
 error: 1: expected 'int', but found 'float'
 error: 2: type mismatch: '=' cannot operate on 'int', 'float'
 error: 3: type mismatch: '*=' cannot operate on 'int3', 'float'
-error: 4: type mismatch: ',' cannot operate on '<INVALID>', 'int'
-error: 5: type mismatch: ',' cannot operate on '<INVALID>', 'int'
+error: 4: expected '(' to begin function call
+error: 5: expected '(' to begin constructor invocation
 error: 6: expected '(' to begin function call
 error: 7: expected '(' to begin constructor invocation
 7 errors