Disable questionable bmps on Mac platform decoder

These are already disabled on WIC, but they are supported by SkCodec.

Bug: skia:6984
Change-Id: Ib248749f357debcc173dfaa2bcd5adc8da52df22
Reviewed-on: https://skia-review.googlesource.com/36440
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
This commit is contained in:
Leon Scroggins III 2017-08-18 13:08:16 -04:00 committed by Skia Commit-Bot
parent 4189d1b8b7
commit 3a3cf43e1e
12 changed files with 92 additions and 75 deletions

View File

@ -363,6 +363,14 @@
"image", "image",
"gen_platf", "gen_platf",
"testimgari.jpg", "testimgari.jpg",
"_",
"image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"serialize-8888", "serialize-8888",
"gm", "gm",
"_", "_",

View File

@ -362,6 +362,14 @@
"testimgari.jpg", "testimgari.jpg",
"_", "_",
"image", "image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"_", "_",
"interlaced1.png", "interlaced1.png",
"_", "_",

View File

@ -267,14 +267,6 @@
"_", "_",
"image", "image",
"gen_platf", "gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"gen_platf",
"pal8os2v2.bmp", "pal8os2v2.bmp",
"_", "_",
"image", "image",
@ -314,6 +306,14 @@
"testimgari.jpg", "testimgari.jpg",
"_", "_",
"image", "image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"_", "_",
"interlaced1.png", "interlaced1.png",
"_", "_",

View File

@ -273,14 +273,6 @@
"_", "_",
"image", "image",
"gen_platf", "gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"gen_platf",
"pal8os2v2.bmp", "pal8os2v2.bmp",
"_", "_",
"image", "image",
@ -320,6 +312,14 @@
"testimgari.jpg", "testimgari.jpg",
"_", "_",
"image", "image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"_", "_",
"interlaced1.png", "interlaced1.png",
"_", "_",

View File

@ -270,14 +270,6 @@
"_", "_",
"image", "image",
"gen_platf", "gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"gen_platf",
"pal8os2v2.bmp", "pal8os2v2.bmp",
"_", "_",
"image", "image",
@ -317,6 +309,14 @@
"testimgari.jpg", "testimgari.jpg",
"_", "_",
"image", "image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"_", "_",
"interlaced1.png", "interlaced1.png",
"_", "_",

View File

@ -267,14 +267,6 @@
"_", "_",
"image", "image",
"gen_platf", "gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"gen_platf",
"pal8os2v2.bmp", "pal8os2v2.bmp",
"_", "_",
"image", "image",
@ -314,6 +306,14 @@
"testimgari.jpg", "testimgari.jpg",
"_", "_",
"image", "image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"_", "_",
"interlaced1.png", "interlaced1.png",
"_", "_",

View File

@ -267,14 +267,6 @@
"_", "_",
"image", "image",
"gen_platf", "gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"gen_platf",
"pal8os2v2.bmp", "pal8os2v2.bmp",
"_", "_",
"image", "image",
@ -314,6 +306,14 @@
"testimgari.jpg", "testimgari.jpg",
"_", "_",
"image", "image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"_", "_",
"interlaced1.png", "interlaced1.png",
"_", "_",

View File

@ -272,14 +272,6 @@
"_", "_",
"image", "image",
"gen_platf", "gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"gen_platf",
"pal8os2v2.bmp", "pal8os2v2.bmp",
"_", "_",
"image", "image",
@ -319,6 +311,14 @@
"testimgari.jpg", "testimgari.jpg",
"_", "_",
"image", "image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"_", "_",
"interlaced1.png", "interlaced1.png",
"_", "_",

View File

@ -267,14 +267,6 @@
"_", "_",
"image", "image",
"gen_platf", "gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"gen_platf",
"pal8os2v2.bmp", "pal8os2v2.bmp",
"_", "_",
"image", "image",
@ -314,6 +306,14 @@
"testimgari.jpg", "testimgari.jpg",
"_", "_",
"image", "image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"_", "_",
"interlaced1.png", "interlaced1.png",
"_", "_",

View File

@ -272,14 +272,6 @@
"_", "_",
"image", "image",
"gen_platf", "gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"gen_platf",
"pal8os2v2.bmp", "pal8os2v2.bmp",
"_", "_",
"image", "image",
@ -317,6 +309,14 @@
"image", "image",
"gen_platf", "gen_platf",
"testimgari.jpg", "testimgari.jpg",
"_",
"image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"serialize-8888", "serialize-8888",
"gm", "gm",
"_", "_",

View File

@ -294,14 +294,6 @@
"_", "_",
"image", "image",
"gen_platf", "gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"_",
"image",
"gen_platf",
"pal8os2v2.bmp", "pal8os2v2.bmp",
"_", "_",
"image", "image",
@ -343,6 +335,14 @@
"image", "image",
"gen_platf", "gen_platf",
"testimgari.jpg", "testimgari.jpg",
"_",
"image",
"gen_platf",
"rle8-height-negative.bmp",
"_",
"image",
"gen_platf",
"rle4-height-negative.bmp",
"serialize-8888", "serialize-8888",
"gm", "gm",
"_", "_",

View File

@ -287,8 +287,6 @@ def dm_flags(api, bot):
# WIC fails on questionable bmps # WIC fails on questionable bmps
if 'Win' in bot: if 'Win' in bot:
blacklist('_ image gen_platf rle8-height-negative.bmp')
blacklist('_ image gen_platf rle4-height-negative.bmp')
blacklist('_ image gen_platf pal8os2v2.bmp') blacklist('_ image gen_platf pal8os2v2.bmp')
blacklist('_ image gen_platf pal8os2v2-16.bmp') blacklist('_ image gen_platf pal8os2v2-16.bmp')
blacklist('_ image gen_platf rgba32abf.bmp') blacklist('_ image gen_platf rgba32abf.bmp')
@ -302,9 +300,12 @@ def dm_flags(api, bot):
# This GM triggers a SkSmallAllocator assert. # This GM triggers a SkSmallAllocator assert.
blacklist('_ gm _ composeshader_bitmap') blacklist('_ gm _ composeshader_bitmap')
# WIC and CG fail on arithmetic jpegs
if 'Win' in bot or 'Mac' in bot: if 'Win' in bot or 'Mac' in bot:
# WIC and CG fail on arithmetic jpegs
blacklist('_ image gen_platf testimgari.jpg') blacklist('_ image gen_platf testimgari.jpg')
# More questionable bmps that fail on Mac, too. skbug.com/6984
blacklist('_ image gen_platf rle8-height-negative.bmp')
blacklist('_ image gen_platf rle4-height-negative.bmp')
if 'Android' in bot or 'iOS' in bot: if 'Android' in bot or 'iOS' in bot:
# This test crashes the N9 (perhaps because of large malloc/frees). It also # This test crashes the N9 (perhaps because of large malloc/frees). It also