AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

temporarily disable BadImage test on new ASAN bot

Browse Source 
Here's the current error:

==6835==WARNING: AddressSanitizer failed to allocate 0xc0000028 bytes
==6835==AddressSanitizer's allocator is terminating the process instead of returning 0
==6835==If you don't like this behavior set allocator_may_return_null=1
==6835==AddressSanitizer CHECK failed: external/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:221 "((0)) != (0)" (0x0, 0x0)

Looking at how sk_malloc and co all funnel into sk_malloc_flags(), and
how our local sk_malloc_flags() works, I think everything would be fine
to run this bot with allocator_may_return_null=1, but I'm not sure how
to do that.

Change-Id: I155439e17dd6353b82056de12f49de34e9538643
Reviewed-on: https://skia-review.googlesource.com/101660
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
This commit is contained in:
Mike Klein 2018-01-30 08:08:49 -05:00 committed by Skia Commit-Bot
parent 6da98f1095
commit 3a3fbf16c3
2 changed files with 1070 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1064
infra/bots/recipes/test.expected/Test-Android-Clang-Nexus5x-GPU-Adreno418-arm-Debug-All-Android_ASAN.json Normal file
View File

File diff suppressed because it is too large Load Diff

8
infra/bots/recipes/test.py
View File

@ -709,6 +709,10 @@ def dm_flags(api, bot):
if 'PowerVRGX6250' in bot:
match.append('~gradients_view_perspective_nodither') #skia:6972
if '-arm-' in bot and 'ASAN' in bot:
# TODO: can we run with env allocator_may_return_null=1 instead?
match.append('~BadImage')
if blacklisted:
args.append('--blacklist')
args.extend(blacklisted)
@ -912,8 +916,8 @@ TEST_BUILDERS = [
'Test-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-All-Android',
'Test-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-All-Android_CCPR',
'Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-All-Android',
('Test-Android-Clang-Nexus5x-GPU-Adreno418-arm64-Debug-All'
'-Android_ASAN'),
'Test-Android-Clang-Nexus5x-GPU-Adreno418-arm-Debug-All-Android_ASAN',
'Test-Android-Clang-Nexus5x-GPU-Adreno418-arm64-Debug-All-Android_ASAN',
('Test-Android-Clang-Nexus5x-GPU-Adreno418-arm64-Debug-All'
'-Android_NoGPUThreads'),
'Test-Android-Clang-Nexus7-CPU-Tegra3-arm-Release-All-Android',