AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

rewrite path.getBounds test to work-around compiler bug

Browse Source 
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1262143002
This commit is contained in:
reed 2015-07-29 08:37:13 -07:00 committed by Commit bot
parent 117842223b
commit 3b2fb981ab
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tests/PathTest.cpp
View File

@ -568,9 +568,19 @@ static void test_clipped_cubic() {
}
}
static void dump_if_ne(skiatest::Reporter* reporter, const SkRect& expected, const SkRect& bounds) {
if (expected != bounds) {
ERRORF(reporter, "path.getBounds() returned [%g %g %g %g], but expected [%g %g %g %g]",
bounds.left(), bounds.top(), bounds.right(), bounds.bottom(),
expected.left(), expected.top(), expected.right(), expected.bottom());
}
}
static void test_bounds_crbug_513799(skiatest::Reporter* reporter) {
SkPath path;
#if 0
// As written these tests were failing on LLVM 4.2 MacMini Release mysteriously, so we've
// rewritten them to avoid this (compiler-bug?).
REPORTER_ASSERT(reporter, SkRect::MakeLTRB(0, 0, 0, 0) == path.getBounds());
path.moveTo(-5, -8);
@ -581,6 +591,18 @@ static void test_bounds_crbug_513799(skiatest::Reporter* reporter) {
path.moveTo(1, 2);
REPORTER_ASSERT(reporter, SkRect::MakeLTRB(-5, -8, 3, 4) == path.getBounds());
#else
dump_if_ne(reporter, SkRect::MakeLTRB(0, 0, 0, 0), path.getBounds());
path.moveTo(-5, -8); // should set the bounds
dump_if_ne(reporter, SkRect::MakeLTRB(-5, -8, -5, -8), path.getBounds());
path.addRect(SkRect::MakeLTRB(1, 2, 3, 4)); // should extend the bounds
dump_if_ne(reporter, SkRect::MakeLTRB(-5, -8, 3, 4), path.getBounds());
path.moveTo(1, 2); // don't expect this to have changed the bounds
dump_if_ne(reporter, SkRect::MakeLTRB(-5, -8, 3, 4), path.getBounds());
#endif
}
// Inspired by http://ie.microsoft.com/testdrive/Performance/Chalkboard/