AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Eliminate fOwnedNodes from symbol tables.

Browse Source 
Now that DSLFP is gone, no one uses this. Previously, this was used to
stash the `sk_SampleCoord` Variable symbol:
https://skia-review.googlesource.com/c/skia/+/540301/1/src/sksl/dsl/DSLVar.cpp#b148

Change-Id: I4015dd7b29da004cd308fb21570a23014a2c66d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/540303
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
This commit is contained in:
John Stiles 2022-05-14 00:02:17 -04:00 committed by SkCQ
parent 4c2f5c305f
commit 3bc68ed74c
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/sksl/ir/SkSLSymbolTable.h
View File

@ -93,13 +93,6 @@ public:
return ptr;
}
template <typename T>
const T* takeOwnershipOfIRNode(std::unique_ptr<T> node) {
const T* ptr = node.get();
fOwnedNodes.push_back(std::move(node));
return ptr;
}
/**
* Given type = `float` and arraySize = 5, creates the array type `float[5]` in the symbol
* table. The created array type is returned. If zero is passed, the base type is returned
@ -158,7 +151,6 @@ private:
static std::vector<const FunctionDeclaration*> GetFunctions(const Symbol& s);
bool fBuiltin = false;
std::vector<std::unique_ptr<IRNode>> fOwnedNodes;
std::forward_list<std::string> fOwnedStrings;
SkTHashMap<SymbolKey, const Symbol*, SymbolKey::Hash> fSymbols;
const Context& fContext;