AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove one un-needed static initializer

Browse Source 
This patch removes the use of a static C++ object in the
implementation of SkMatrix44::isIdentity(). Instead, we rely
on direct comparison with a statically allocated array of
SkMScalar values, which is completely equivalent.
Review URL: http://codereview.appspot.com/5502067

git-svn-id: http://skia.googlecode.com/svn/trunk@2991 2bbb7eff-a529-9590-31e7-b0007b416f81
This commit is contained in:
digit@google.com 2012-01-10 10:00:59 +00:00
parent fa394d491b
commit 3e05f29116
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/utils/SkMatrix44.cpp
View File

@ -84,10 +84,14 @@ void SkMatrix44::asRowMajord(double dst[]) const {
///////////////////////////////////////////////////////////////////////////////
static const SkMatrix44 gIdentity44;
bool SkMatrix44::isIdentity() const {
return *this == gIdentity44;
static const SkMScalar sIdentityMat[4][4] = {
{ 1, 0, 0, 0 },
{ 0, 1, 0, 0 },
{ 0, 0, 1, 0 },
{ 0, 0, 0, 1 },
};
return !memcmp(fMat, sIdentityMat, sizeof(fMat));
}
///////////////////////////////////////////////////////////////////////////////