AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Re-enable tessellation for cacheable paths"

Browse Source 
This reverts commit dbed577501.

Reason for revert: Indirect draw regression for filled paths on Adreno

Original change's description:
> Re-enable tessellation for cacheable paths
>
> Now that the fixed count stroke tessellator has landed, these should
> hopefully not regress performance.
>
> Bug: skia:11138
> Bug: skia:11139
> Change-Id: Ifdcd817705d394ea6d0f932711ed725a66a7fc91
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/403956
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

TBR=egdaniel@google.com,csmartdalton@google.com

Change-Id: I2c9b76636ef4532eadb56f00663750ce40d55c41
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:11138
Bug: skia:11139
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/404397
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This commit is contained in:
Chris Dalton 2021-05-04 20:43:12 +00:00 committed by Skia Commit-Bot
parent 4fc3a01159
commit 46d0c04b3d
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/gpu/tessellate/GrTessellationPathRenderer.cpp
View File

@ -137,6 +137,15 @@ GrPathRenderer::CanDrawPath GrTessellationPathRenderer::onCanDrawPath(
!args.fProxy->canUseStencil(*args.fCaps)) {
return CanDrawPath::kNo;
}
// On platforms that don't have native support for indirect draws and/or hardware tessellation,
// we find that cached triangulations of strokes can render slightly faster. Let cacheable paths
// go to the triangulator on these platforms for now.
// (crbug.com/1163441, skbug.com/11138, skbug.com/11139)
if (!args.fCaps->nativeDrawIndirectSupport() &&
!args.fCaps->shaderCaps()->tessellationSupport() &&
shape.hasUnstyledKey()) { // Is the path cacheable?
return CanDrawPath::kNo;
}
return CanDrawPath::kYes;
}