AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

do not b.expiration(...) for FM

Browse Source 
Caveat: I don't know what expiration is, except it makes bots go purple.

It looks like the default is 4 hours, and the DM and Perf bots set their
expiration even higher than that, 20-48 hours.  (Similarly, they set
higher timeouts than default, where FM uses the default.)

I figure I might as well move expiration up to the default, and then if
tasks are still expiring, start marching them up towards DM/Perf tasks.

Change-Id: I35dbd8ed8939cc6a62240947120858ba186c86b7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/379000
Reviewed-by: Weston Tracey <westont@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This commit is contained in:
Mike Klein 2021-03-03 11:23:09 -06:00 committed by Skia Commit-Bot
parent e4da7b672f
commit 46d9bb255d
2 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
infra/bots/gen_tasks_logic/gen_tasks_logic.go
View File

@ -1584,7 +1584,6 @@ func (b *jobBuilder) fm() {
"build/fm${EXECUTABLE_SUFFIX}")
b.serviceAccount(b.cfg.ServiceAccountCompile)
b.swarmDimensions()
b.expiration(15 * time.Minute)
b.attempts(1)
if b.isLinux() && b.matchExtraConfig("SAN") {

10
infra/bots/tasks.json
View File

@ -14841,7 +14841,6 @@
"os:Debian-10.3",
"pool:Skia"
],
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},
@ -14904,7 +14903,6 @@
"clang_linux/bin"
]
},
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},
@ -14967,7 +14965,6 @@
"clang_linux/bin"
]
},
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},
@ -15030,7 +15027,6 @@
"clang_linux/bin"
]
},
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},
@ -15079,7 +15075,6 @@
"os:Mac-10.15.7",
"pool:Skia"
],
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},
@ -15128,7 +15123,6 @@
"os:Mac-10.15.7",
"pool:Skia"
],
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},
@ -15177,7 +15171,6 @@
"os:Mac-10.15.7",
"pool:Skia"
],
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},
@ -15227,7 +15220,6 @@
"os:Windows-Server-17763",
"pool:Skia"
],
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},
@ -15277,7 +15269,6 @@
"os:Windows-Server-17763",
"pool:Skia"
],
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},
@ -15327,7 +15318,6 @@
"os:Windows-Server-17763",
"pool:Skia"
],
"expiration_ns": 900000000000,
"max_attempts": 1,
"service_account": "skia-external-compile-tasks@skia-swarming-bots.iam.gserviceaccount.com"
},