AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update Valgrind match-leak-kinds for keep-alive thread.

Browse Source 
Valgrind has tipped over from seeing the keep-alive thread as possibly
leaked to seeing it as definitely leaked.  We can suppress both.

An alternative here is "all" or to just remove the line.  For the moment
I think this is best, as we're still excluding indirect leaks this way.
I'd want to think a bit whether it made sense for the keep-alive thread
to indirectly leak anything, so I'd like it to fail if it comes up.

Change-Id: Ib28790a1d84a0a9061fdb6de48569ca8ea51b52a
Reviewed-on: https://skia-review.googlesource.com/8764
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
This commit is contained in:
Mike Klein 2017-02-21 08:12:09 -05:00 committed by Skia Commit-Bot
parent 0548a21dd5
commit 4a2ab86d76
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/valgrind.supp
View File

@ -4,7 +4,7 @@
{
nanobench_and_dm_keepalive_thread_leak
Memcheck:Leak
match-leak-kinds: possible
match-leak-kinds: possible,definite
...
fun:_ZN8SkThreadC1EPFvPvES0_
...