AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert of Disable NEON procs for box blur as it produces invalid results (patchset #1 id:1 of https://codereview.chromium.org/520963002/)

Browse Source 
Reason for revert:
failing more GMs than expected.

Original issue's description:
> Disable NEON procs for box blur as it produces invalid results
>
> BUG=skia:2845
>
> Committed: https://skia.googlesource.com/skia/+/4a1764688c990fb926aaeab538497dad52768d99

R=senorblanco@google.com, mtklein@google.com
TBR=mtklein@google.com, senorblanco@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/531023002
This commit is contained in:
djsollen 2014-09-02 06:32:25 -07:00 committed by Commit bot
parent 4a1764688c
commit 4d6484e764
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
expectations/gm/ignored-tests.txt
View File

@ -44,7 +44,3 @@ matrixconvolution
# Added as part of https://codereview.chromium.org/466363009/ # Added as part of https://codereview.chromium.org/466363009/
fontcache fontcache
# fix broken blurs on android (djsollen
# http://skbug.com/2845
imageblur2

5
src/opts/SkBlurImage_opts_arm.cpp
View File

@ -12,11 +12,10 @@ bool SkBoxBlurGetPlatformProcs(SkBoxBlurProc* boxBlurX,
SkBoxBlurProc* boxBlurY, SkBoxBlurProc* boxBlurY,
SkBoxBlurProc* boxBlurXY, SkBoxBlurProc* boxBlurXY,
SkBoxBlurProc* boxBlurYX) { SkBoxBlurProc* boxBlurYX) {
// Temporary workaround for http://skbug.com/2845
return false;
#if SK_ARM_NEON_IS_NONE #if SK_ARM_NEON_IS_NONE
return false; return false;
#elif defined(SK_CPU_ARM64) // Temporary fix for
return false; // http://skbug.com/2845
#else #else
#if SK_ARM_NEON_IS_DYNAMIC #if SK_ARM_NEON_IS_DYNAMIC
if (!sk_cpu_arm_has_neon()) { if (!sk_cpu_arm_has_neon()) {