AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove RGB8 Mali-400 workaround

Browse Source 
Cq-Include-Trybots: luci.skia.skia.primary:Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-All-Android
Bug: chromium:1150368
Change-Id: I0d66fd16edade9bad33603e73c3708c33662e673
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/341723
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
This commit is contained in:
Brian Salomon 2020-12-08 11:48:15 -05:00 committed by Skia Commit-Bot
parent 8b5f3ac3eb
commit 51ab694cbb
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/gpu/gl/GrGLCaps.cpp
View File

@ -2345,9 +2345,6 @@ void GrGLCaps::initFormatTable(const GrGLContextInfo& ctxInfo, const GrGLInterfa
info.fInternalFormatForTexImageOrStorage = info.fInternalFormatForTexImageOrStorage =
texImageSupportsSizedInternalFormat ? GR_GL_RGB8 : GR_GL_RGB; texImageSupportsSizedInternalFormat ? GR_GL_RGB8 : GR_GL_RGB;
} }
if (formatWorkarounds.fDisableRGB8ForMali400) {
info.fFlags = 0;
}
info.fColorTypeInfoCount = 1; info.fColorTypeInfoCount = 1;
info.fColorTypeInfos = std::make_unique<ColorTypeInfo[]>(info.fColorTypeInfoCount); info.fColorTypeInfos = std::make_unique<ColorTypeInfo[]>(info.fColorTypeInfoCount);
@ -3991,9 +3988,6 @@ void GrGLCaps::applyDriverCorrectnessWorkarounds(const GrGLContextInfo& ctxInfo,
kIntel_GrGLDriver == ctxInfo.driver() && GR_IS_GR_GL_ES(ctxInfo.standard()); kIntel_GrGLDriver == ctxInfo.driver() && GR_IS_GR_GL_ES(ctxInfo.standard());
#endif #endif
// Mali-400 fails ReadPixels tests, mostly with non-0xFF alpha values when read as GL_RGBA8.
formatWorkarounds->fDisableRGB8ForMali400 = kMali4xx_GrGLRenderer == ctxInfo.renderer();
// On the Intel Iris 6100, interacting with LUM16F seems to confuse the driver. After // On the Intel Iris 6100, interacting with LUM16F seems to confuse the driver. After
// writing to/reading from a LUM16F texture reads from/writes to other formats behave // writing to/reading from a LUM16F texture reads from/writes to other formats behave
// erratically. // erratically.

1
src/gpu/gl/GrGLCaps.h
View File

@ -483,7 +483,6 @@ private:
bool fDisableSRGBRenderWithMSAAForMacAMD = false; bool fDisableSRGBRenderWithMSAAForMacAMD = false;
bool fDisableRGBA16FTexStorageForCrBug1008003 = false; bool fDisableRGBA16FTexStorageForCrBug1008003 = false;
bool fDisableBGRATextureStorageForIntelWindowsES = false; bool fDisableBGRATextureStorageForIntelWindowsES = false;
bool fDisableRGB8ForMali400 = false;
bool fDisableLuminance16F = false; bool fDisableLuminance16F = false;
bool fDontDisableTexStorageOnAndroid = false; bool fDontDisableTexStorageOnAndroid = false;
bool fDisallowDirectRG8ReadPixels = false; bool fDisallowDirectRG8ReadPixels = false;