Make nanobench --outResultsFile only work with Release builds.
It is very, very misleading to report performance numbers for Debug builds. This makes it impossible for us to upload them to perf.skia.org. BUG=skia:4828 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606323002 Review URL: https://codereview.chromium.org/1606323002
This commit is contained in:
parent
b1475b0d41
commit
5352015fa3
@ -1054,7 +1054,12 @@ int nanobench_main() {
|
||||
|
||||
SkAutoTDelete<ResultsWriter> log(new ResultsWriter);
|
||||
if (!FLAGS_outResultsFile.isEmpty()) {
|
||||
#if defined(SK_RELEASE)
|
||||
log.reset(new NanoJSONResultsWriter(FLAGS_outResultsFile[0]));
|
||||
#else
|
||||
SkDebugf("I'm ignoring --outResultsFile because this is a Debug build.");
|
||||
return 1;
|
||||
#endif
|
||||
}
|
||||
|
||||
if (1 == FLAGS_properties.count() % 2) {
|
||||
|
Loading…
Reference in New Issue
Block a user