AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make nanobench --outResultsFile only work with Release builds.

Browse Source 
It is very, very misleading to report performance numbers for Debug builds.
This makes it impossible for us to upload them to perf.skia.org.

BUG=skia:4828
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606323002

Review URL: https://codereview.chromium.org/1606323002
This commit is contained in:
mtklein 2016-01-20 09:53:59 -08:00 committed by Commit bot
parent b1475b0d41
commit 5352015fa3
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bench/nanobench.cpp
View File

@ -1054,7 +1054,12 @@ int nanobench_main() {
SkAutoTDelete<ResultsWriter> log(new ResultsWriter); SkAutoTDelete<ResultsWriter> log(new ResultsWriter);
if (!FLAGS_outResultsFile.isEmpty()) { if (!FLAGS_outResultsFile.isEmpty()) {
#if defined(SK_RELEASE)
log.reset(new NanoJSONResultsWriter(FLAGS_outResultsFile[0])); log.reset(new NanoJSONResultsWriter(FLAGS_outResultsFile[0]));
#else
SkDebugf("I'm ignoring --outResultsFile because this is a Debug build.");
return 1;
#endif
} }
if (1 == FLAGS_properties.count() % 2) { if (1 == FLAGS_properties.count() % 2) {