AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

link test to bug

Browse Source 
crbug.com/526025 includes a minimized SVG test case.
Translating that test case into native code (fuzzTNG)
did not reproduce the bug. That test case should
have not been included with skia issue 1323813003,
and is deleted here.

Running the minimal test case in a modified version
of chrome isolated the bug. The modified version
generated the test fuzz763_3 with the edit

#define DEBUGGING_PATHOPS_FROM_HOST 1

in src/pathops/SkPathopsOp.cpp line 188.

Rename fuzz763_3 to issue_526025 to associate the test
with the bug. Note that the bug contains the body of the
CL in comment $5.

R=reed@google.com

Review URL: https://codereview.chromium.org/1315503005
This commit is contained in:
caryclark 2015-09-01 06:22:36 -07:00 committed by Commit bot
parent f6703fa0aa
commit 580c40ae71
2 changed files with 2 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tests/PathOpsBuilderTest.cpp
View File

@ -270,27 +270,3 @@ DEF_TEST(Fuzz846, reporter) {
SkPath result;
builder.resolve(&result);
}
#include "SkParsePath.h"
DEF_TEST(fuzzTNG, reporter) {
const char* pathStrs[] = {
"M360,-2147483648.000000000000000000000000000000000000000000000000000001 A3240,3240 0.0 0 11 256,256 L100000000,4140 Z",
"M360,4140 A11,-1 0.0 0 0 6840,4140 L100,512 L32,16 L360,1024 Z",
"M360,4140 A3240,1000000001 32768 1024 128 100000000.000000000000000000000000000000000000000000000000000001,512 Z",
"M127,321 L6840,270 L-21474836481,100000000 L2551,64 Z",
"M-128,4140 Z",
};
SkPath clip[SK_ARRAY_COUNT(pathStrs)];
SkOpBuilder builder;
for (size_t i = 0; i < SK_ARRAY_COUNT(pathStrs); ++i) {
SkParsePath::FromSVGString(pathStrs[i], &clip[i]);
builder.add(clip[i], kUnion_SkPathOp);
}
SkPath result;
builder.resolve(&result);
SkPath path;
SkParsePath::FromSVGString("M-315,7425 L4096,7425 L-1000000001,-315 L-315,7425 Z", &path);
builder.add(path, kDifference_SkPathOp);
testPathOp(reporter, result, path, kDifference_SkPathOp, __FUNCTION__);
}

4
tests/PathOpsOpTest.cpp
View File

@ -5164,7 +5164,7 @@ static void fuzz38(skiatest::Reporter* reporter, const char* filename) {
testPathOpCheck(reporter, path, pathB, kUnion_SkPathOp, filename, FLAGS_runFail);
}
static void fuzz763_3(skiatest::Reporter* reporter, const char* filename) {
static void crbug_526025(skiatest::Reporter* reporter, const char* filename) {
SkPath path;
path.setFillType((SkPath::FillType) 1);
path.moveTo(SkBits2Float(0x43b40000), SkBits2Float(0xcf000000)); // 360, -2.14748e+09f
@ -5199,7 +5199,7 @@ static void (*stopTest)(skiatest::Reporter* , const char* filename) = 0;
#define TEST(name) { name, #name }
static struct TestDesc tests[] = {
TEST(fuzz763_3),
TEST(crbug_526025),
TEST(fuzz38),
TEST(cubics44d),
TEST(cubics45u),