AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Expose bounds for maskfilters

Browse Source 
Bug: skia:12094
Change-Id: Ia0dfa15fef2cd2f5fe7e024e085e56880c12224b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/419098
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
This commit is contained in:
Mike Reed 2021-06-16 15:18:30 -04:00 committed by Skia Commit-Bot
parent 3e4ef49890
commit 5837aad590
4 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/core/SkMaskFilter.h
View File

@ -40,6 +40,13 @@ public:
return kSkMaskFilter_Type;
}
/**
* Returns the approximate bounds that would result from filtering the src rect.
* The actual result may be different, but it should be contained within the
* returned bounds.
*/
SkRect approximateFilteredBounds(const SkRect& src) const;
static sk_sp<SkMaskFilter> Deserialize(const void* data, size_t size,
const SkDeserialProcs* procs = nullptr) {
return sk_sp<SkMaskFilter>(static_cast<SkMaskFilter*>(

3
src/core/SkBlurMF.cpp
View File

@ -547,6 +547,9 @@ SkBlurMaskFilterImpl::filterRectsToNine(const SkRect rects[], int count,
void SkBlurMaskFilterImpl::computeFastBounds(const SkRect& src,
SkRect* dst) const {
// TODO: if we're doing kInner blur, should we return a different outset?
// i.e. pad == 0 ?
SkScalar pad = 3.0f * fSigma;
dst->setLTRB(src.fLeft - pad, src.fTop - pad,

6
src/core/SkMaskFilter.cpp
View File

@ -368,6 +368,12 @@ void SkMaskFilterBase::computeFastBounds(const SkRect& src, SkRect* dst) const {
}
}
SkRect SkMaskFilter::approximateFilteredBounds(const SkRect& src) const {
SkRect dst;
as_MFB(this)->computeFastBounds(src, &dst);
return dst;
}
void SkMaskFilter::RegisterFlattenables() {
sk_register_blur_maskfilter_createproc();
#if SK_SUPPORT_GPU

7
tests/BlurTest.cpp
View File

@ -386,6 +386,13 @@ DEF_TEST(BlurAsABlur, reporter) {
} else {
REPORTER_ASSERT(reporter, !success);
}
const SkRect src = {0, 0, 100, 100};
const auto dst = mf->approximateFilteredBounds(src);
// This is a very conservative test. With more knowledge, we could
// consider more stringent tests.
REPORTER_ASSERT(reporter, dst.contains(src));
}
}
}