AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Performance experiment: Disable SkSL optimization in nanobench/skpbench

Browse Source 
Change-Id: I974571e7e0e9d0170f92b970d425d9ce530e312e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/369716
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This commit is contained in:
Brian Osman 2021-02-12 09:14:07 -05:00 committed by Skia Commit-Bot
parent bb1505f2ab
commit 5ad759065d
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bench/nanobench.cpp
View File

@ -65,6 +65,7 @@ extern bool gSkForceRasterPipelineBlitter;
extern bool gUseSkVMBlitter;
extern bool gSkVMAllowJIT;
extern bool gSkVMJITViaDylib;
extern bool gSkSLAllowOptimization;
#ifndef SK_BUILD_FOR_WIN
#include <unistd.h>
@ -1240,6 +1241,7 @@ int main(int argc, char** argv) {
gSkForceRasterPipelineBlitter = FLAGS_forceRasterPipeline;
gUseSkVMBlitter = FLAGS_skvm;
gSkVMAllowJIT = gSkVMJITViaDylib = FLAGS_jit;
gSkSLAllowOptimization = false; // Temporary experiment
int runs = 0;
BenchmarkStream benchStream;

4
src/sksl/SkSLCompiler.cpp
View File

@ -67,6 +67,8 @@
#endif
bool gSkSLAllowOptimization = true;
namespace SkSL {
using RefKind = VariableReference::RefKind;
@ -1606,7 +1608,7 @@ std::unique_ptr<Program> Compiler::convertProgram(
bool success = false;
if (fErrorCount) {
// Do not return programs that failed to compile.
} else if (settings.fOptimize && !this->optimize(*program)) {
} else if (settings.fOptimize && gSkSLAllowOptimization && !this->optimize(*program)) {
// Do not return programs that failed to optimize.
} else {
// We have a successful program!

4
tools/skpbench/skpbench.cpp
View File

@ -88,6 +88,8 @@ static const char resultFormat[] =
static constexpr int kNumFlushesToPrimeCache = 3;
extern bool gSkSLAllowOptimization;
struct Sample {
using duration = std::chrono::nanoseconds;
@ -496,6 +498,8 @@ int main(int argc, char** argv) {
exit(0); // This can be used to print the header and quit.
}
gSkSLAllowOptimization = false; // Temporary experiment
// Parse the config.
const SkCommandLineConfigGpu* config = nullptr; // Initialize for spurious warning.
SkCommandLineConfigArray configs;