Remove MULTILINE, ^, and $ from re finding actual_results.json.
MULTILINE, ^, and $ work based on the platform, but the files being parsed are from other platforms. As a result, the current code for extracting the actual_results.json version will not find it in logfiles produced on Windows when run on Mac. The code for extracting the exact actual_results.json file to use from a logfile is itself something of a hack, as this information should be provided ina more structured manner. This proposed method of finding the exact file is no worse than the old one, and in cases like above, better. Review URL: https://codereview.chromium.org/789253002
This commit is contained in:
parent
387a01a635
commit
5bec916cf6
@ -162,8 +162,8 @@ class RietveldIssueActuals(object):
|
||||
"""
|
||||
result = dict()
|
||||
json_filename_re = re.compile(
|
||||
'^Created: gs://([^/]+)/((?:[^/]+/)+%s)#(\d+)$'
|
||||
% re.escape(self._json_filename), re.MULTILINE)
|
||||
'Created: gs://([^/]+)/((?:[^/]+/)+%s)#(\d+)'
|
||||
% re.escape(self._json_filename))
|
||||
codereview_api_url = 'https://codereview.chromium.org/api'
|
||||
upload_gm_step_url = '/steps/Upload GM Results/logs/stdio'
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user