AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Qiet ASAN warnings about ieee float division

Browse Source 
TBR=michaelludwig@google.com
Change-Id: I4f950060ea75203531f081f3b62e805cadc0adf5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331484
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This commit is contained in:
Chris Dalton 2020-11-02 17:26:30 -07:00 committed by Skia Commit-Bot
parent 6bacd9ff2f
commit 5f3f8a08b7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/gpu/geometry/GrPathUtils.cpp
View File

@ -585,7 +585,7 @@ void GrPathUtils::convertCubicToQuadsConstrainToTangents(const SkPoint p[4],
} }
} }
static inline bool is_float_inside_0_1_exclusive(float x) { static inline bool is_ieee_float_inside_0_1_exclusive(float x) {
constexpr static uint32_t kIEEE_one = 127 << 23; constexpr static uint32_t kIEEE_one = 127 << 23;
return sk_bit_cast<uint32_t>(x) - 1 < kIEEE_one - 1; return sk_bit_cast<uint32_t>(x) - 1 < kIEEE_one - 1;
} }
@ -641,8 +641,8 @@ int GrPathUtils::findCubicConvex180Chops(const SkPoint pts[], float T[2]) {
// NOTE: if C == 0, then C != tan0. But this is fine because the curve is definitely // NOTE: if C == 0, then C != tan0. But this is fine because the curve is definitely
// convex-180 if any points are colocated, and T[0] will equal NaN which returns 0 // convex-180 if any points are colocated, and T[0] will equal NaN which returns 0
// chops. // chops.
float root = c / b_over_minus_2; float root = sk_ieee_float_divide(c, b_over_minus_2);
if (is_float_inside_0_1_exclusive(root)) { if (is_ieee_float_inside_0_1_exclusive(root)) {
T[0] = root; T[0] = root;
return 1; return 1;
} }