AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Temporarily revert just Multiply to see if that's the source of NEON diffs.

Browse Source 
Local testing is confusing and inconclusive.  Pulling out the big guns.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5b9f352ff1e245dd48e200f8f8b683f4569547d3

Review URL: https://codereview.chromium.org/1129293005
This commit is contained in:
mtklein 2015-05-14 10:35:33 -07:00 committed by Commit bot
parent af953bbdfb
commit 6095260e55
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/SkXfermode.cpp
View File

@ -1489,7 +1489,9 @@ SkXfermode* create_mode(int iMode) {
switch (mode) { switch (mode) {
case SkXfermode::kSrcATop_Mode: return SkT4pxXfermode<SrcATop4f>::Create(rec); case SkXfermode::kSrcATop_Mode: return SkT4pxXfermode<SrcATop4f>::Create(rec);
case SkXfermode::kDstATop_Mode: return SkT4pxXfermode<DstATop4f>::Create(rec); case SkXfermode::kDstATop_Mode: return SkT4pxXfermode<DstATop4f>::Create(rec);
case SkXfermode::kXor_Mode: return SkT4pxXfermode<Xor4f>::Create(rec); // Temporarily reverted to see if this is the source of NEON diffs.
// If not, try DstATop then SrcATop next. Multiply is not the problem.
// case SkXfermode::kXor_Mode: return SkT4pxXfermode<Xor4f>::Create(rec);
case SkXfermode::kPlus_Mode: return SkT4pxXfermode<Plus4f>::Create(rec); case SkXfermode::kPlus_Mode: return SkT4pxXfermode<Plus4f>::Create(rec);
case SkXfermode::kModulate_Mode: return SkT4pxXfermode<Modulate4f>::Create(rec); case SkXfermode::kModulate_Mode: return SkT4pxXfermode<Modulate4f>::Create(rec);
case SkXfermode::kScreen_Mode: return SkT4pxXfermode<Screen4f>::Create(rec); case SkXfermode::kScreen_Mode: return SkT4pxXfermode<Screen4f>::Create(rec);