Return -1 in error condition instead of removing diff result.
BUG=skia:2160 R=epoger@google.com Review URL: https://codereview.chromium.org/145123013 git-svn-id: http://skia.googlecode.com/svn/trunk@13407 2bbb7eff-a529-9590-31e7-b0007b416f81
This commit is contained in:
parent
09f0ba7eb3
commit
60bce6cfcc
@ -107,8 +107,8 @@ void SkDiffContext::addDiff(const char* baselinePath, const char* testPath) {
|
||||
diffData.fDiffName = differ->getName();
|
||||
|
||||
if (!differ->diff(&baselineBitmap, &testBitmap, alphaMaskPending, &diffData.fResult)) {
|
||||
// if the diff failed the remove its entry from the list
|
||||
newRecord->fDiffs.pop_back();
|
||||
// if the diff failed record -1 as the result
|
||||
diffData.fResult = -1;
|
||||
continue;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user