AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Output different error for when CL cannot be created in canary task driver

Browse Source 
Bug: skia:10477
Change-Id: I46a48185977a409225583aea58f5fd31cf306d4c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/303266
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
This commit is contained in:
Ravi Mistry 2020-07-17 10:00:04 -04:00 committed by Skia Commit-Bot
parent 324e3e521f
commit 60bf6924b4
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
infra/bots/task_drivers/canary/canary.go
View File

@ -6,6 +6,7 @@ package main
import (
"context"
"errors"
"flag"
"fmt"
"time"
@ -114,6 +115,9 @@ func waitForCanaryRoll(parentCtx context.Context, manualRollDB manual.DB, rollId
if roll.Result == manual.RESULT_SUCCESS {
return nil
} else if roll.Result == manual.RESULT_FAILURE {
if cl == "" {
return td.FailStep(ctx, errors.New("Canary roll could not be created. Ask the trooper to investigate (or directly ping rmistry@)."))
}
return td.FailStep(ctx, fmt.Errorf("Canary roll [ %s ] failed", cl))
} else if roll.Result == manual.RESULT_UNKNOWN {
return td.FailStep(ctx, fmt.Errorf("Canary roll [ %s ] completed with an unknown result", cl))