AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed early_fragment_tests layout qualifier

Browse Source 
This layout qualifier is not actually used anywhere.

Change-Id: I817c9affdd00e492c70f251eb52680644b7ff3f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/406141
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
This commit is contained in:
Ethan Nicholas 2021-05-10 16:13:10 -04:00 committed by Skia Commit-Bot
parent 99ebb17aed
commit 614fb1ef9c
10 changed files with 57 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
include/private/SkSLLayout.h
View File

@ -21,26 +21,25 @@ struct Layout {
enum Flag {
kOriginUpperLeft_Flag = 1 << 0,
kOverrideCoverage_Flag = 1 << 1,
kEarlyFragmentTests_Flag = 1 << 2,
kPushConstant_Flag = 1 << 3,
kBlendSupportAllEquations_Flag = 1 << 4,
kTracked_Flag = 1 << 5,
kSRGBUnpremul_Flag = 1 << 6,
kKey_Flag = 1 << 7,
kPushConstant_Flag = 1 << 2,
kBlendSupportAllEquations_Flag = 1 << 3,
kTracked_Flag = 1 << 4,
kSRGBUnpremul_Flag = 1 << 5,
kKey_Flag = 1 << 6,
// These flags indicate if the qualifier appeared, regardless of the accompanying value.
kLocation_Flag = 1 << 8,
kOffset_Flag = 1 << 9,
kBinding_Flag = 1 << 10,
kIndex_Flag = 1 << 11,
kSet_Flag = 1 << 12,
kBuiltin_Flag = 1 << 13,
kInputAttachmentIndex_Flag = 1 << 14,
kPrimitive_Flag = 1 << 15,
kMaxVertices_Flag = 1 << 16,
kInvocations_Flag = 1 << 17,
kWhen_Flag = 1 << 18,
kCType_Flag = 1 << 19,
kLocation_Flag = 1 << 7,
kOffset_Flag = 1 << 8,
kBinding_Flag = 1 << 9,
kIndex_Flag = 1 << 10,
kSet_Flag = 1 << 11,
kBuiltin_Flag = 1 << 12,
kInputAttachmentIndex_Flag = 1 << 13,
kPrimitive_Flag = 1 << 14,
kMaxVertices_Flag = 1 << 15,
kInvocations_Flag = 1 << 16,
kWhen_Flag = 1 << 17,
kCType_Flag = 1 << 18,
};
enum Primitive {
@ -184,9 +183,6 @@ struct Layout {
if (fFlags & kOverrideCoverage_Flag) {
result += separator() + "override_coverage";
}
if (fFlags & kEarlyFragmentTests_Flag) {
result += separator() + "early_fragment_tests";
}
if (fFlags & kBlendSupportAllEquations_Flag) {
result += separator() + "blend_support_all_equations";
}

2
resources/sksl/errors/LayoutRepeatedQualifiers.sksl
View File

@ -1,7 +1,6 @@
layout (
origin_upper_left,
override_coverage,
early_fragment_tests,
push_constant,
blend_support_all_equations,
tracked,
@ -21,7 +20,6 @@ layout (
origin_upper_left,
override_coverage,
early_fragment_tests,
push_constant,
blend_support_all_equations,
tracked,

4
src/sksl/SkSLParser.cpp
View File

@ -95,7 +95,6 @@ void Parser::InitLayoutMap() {
TOKEN(INPUT_ATTACHMENT_INDEX, "input_attachment_index");
TOKEN(ORIGIN_UPPER_LEFT, "origin_upper_left");
TOKEN(OVERRIDE_COVERAGE, "override_coverage");
TOKEN(EARLY_FRAGMENT_TESTS, "early_fragment_tests");
TOKEN(BLEND_SUPPORT_ALL_EQUATIONS, "blend_support_all_equations");
TOKEN(PUSH_CONSTANT, "push_constant");
TOKEN(POINTS, "points");
@ -920,9 +919,6 @@ Layout Parser::layout() {
case LayoutToken::OVERRIDE_COVERAGE:
setFlag(Layout::kOverrideCoverage_Flag);
break;
case LayoutToken::EARLY_FRAGMENT_TESTS:
setFlag(Layout::kEarlyFragmentTests_Flag);
break;
case LayoutToken::PUSH_CONSTANT:
setFlag(Layout::kPushConstant_Flag);
break;

1
src/sksl/SkSLParser.h
View File

@ -38,7 +38,6 @@ public:
INPUT_ATTACHMENT_INDEX,
ORIGIN_UPPER_LEFT,
OVERRIDE_COVERAGE,
EARLY_FRAGMENT_TESTS,
BLEND_SUPPORT_ALL_EQUATIONS,
PUSH_CONSTANT,
POINTS,

10
src/sksl/generated/sksl_fp.dehydrated.sksl
View File

@ -27,25 +27,25 @@ static uint8_t SKSL_INCLUDE_sksl_fp[] = {255,0,
22,2,0,17,0,
53,3,0,
37,
36,0,32,0,0,255,255,255,255,255,15,0,255,255,255,255,30,0,0,2,31,0,
36,0,16,0,0,255,255,255,255,255,15,0,255,255,255,255,30,0,0,2,31,0,
50,4,0,44,0,0,
0,5,0,
47,4,0,1,
53,6,0,
37,
36,0,32,0,0,255,255,255,255,255,15,39,255,255,255,255,30,0,0,0,51,0,
36,0,16,0,0,255,255,255,255,255,15,39,255,255,255,255,30,0,0,0,51,0,
47,5,0,0,
53,7,0,
37,
36,0,32,0,0,255,255,255,255,255,15,39,255,255,255,255,30,0,0,0,67,0,
36,0,16,0,0,255,255,255,255,255,15,39,255,255,255,255,30,0,0,0,67,0,
50,8,0,84,0,0,
53,9,0,
37,
36,0,32,0,0,255,255,255,255,255,15,39,255,255,255,255,30,0,0,0,90,0,
36,0,16,0,0,255,255,255,255,255,15,39,255,255,255,255,30,0,0,0,90,0,
47,8,0,0,
53,10,0,
37,
36,0,32,0,0,255,255,255,255,255,15,39,255,255,255,255,30,0,0,0,110,0,
36,0,16,0,0,255,255,255,255,255,15,39,255,255,255,255,30,0,0,0,110,0,
47,8,0,0,
53,11,0,
16,135,0,

10
src/sksl/generated/sksl_frag.dehydrated.sksl
View File

@ -11,23 +11,23 @@ static uint8_t SKSL_INCLUDE_sksl_frag[] = {100,0,
49,5,0,
53,1,0,
37,
36,0,32,0,0,255,255,255,255,255,15,0,255,255,255,255,2,0,0,2,3,0,
36,0,16,0,0,255,255,255,255,255,15,0,255,255,255,255,2,0,0,2,3,0,
50,2,0,16,0,0,
53,3,0,
37,
36,0,32,0,0,255,255,255,255,255,17,0,255,255,255,255,2,0,0,2,23,0,
36,0,16,0,0,255,255,255,255,255,17,0,255,255,255,255,2,0,0,2,23,0,
50,4,0,36,0,0,
53,5,0,
37,
36,0,32,0,0,255,255,255,255,255,15,39,255,255,255,255,2,0,0,4,41,0,
36,0,16,0,0,255,255,255,255,255,15,39,255,255,255,255,2,0,0,4,41,0,
50,6,0,66,0,0,
53,7,0,
37,
36,0,41,0,0,0,255,255,0,255,17,39,255,255,255,255,2,0,0,4,72,0,
36,128,20,0,0,0,255,255,0,255,17,39,255,255,255,255,2,0,0,4,72,0,
47,6,0,0,
53,8,0,
37,
36,0,32,0,0,255,255,255,255,255,24,39,255,255,255,255,2,0,0,0,85,0,
36,0,16,0,0,255,255,255,255,255,24,39,255,255,255,255,2,0,0,0,85,0,
47,6,0,0,5,0,
2,0,
1,0,

12
src/sksl/generated/sksl_geom.dehydrated.sksl
View File

@ -16,26 +16,26 @@ static uint8_t SKSL_INCLUDE_sksl_geom[] = {134,0,
49,12,0,
44,1,0,2,0,2,
37,
36,0,32,0,0,255,255,255,255,255,0,0,255,255,255,255,15,0,0,0,16,0,
36,0,16,0,0,255,255,255,255,255,0,0,255,255,255,255,15,0,0,0,16,0,
50,2,0,28,0,
37,
36,0,32,0,0,255,255,255,255,255,1,0,255,255,255,255,15,0,0,0,35,0,
36,0,16,0,0,255,255,255,255,255,1,0,255,255,255,255,15,0,0,0,35,0,
50,3,0,48,0,
53,4,0,
37,
36,0,32,0,0,255,255,255,255,255,18,39,255,255,255,255,15,0,0,2,54,0,
36,0,16,0,0,255,255,255,255,255,18,39,255,255,255,255,15,0,0,2,54,0,
0,5,0,
47,1,0,255,0,
44,6,0,2,0,2,
37,
36,0,32,0,0,255,255,255,255,255,0,0,255,255,255,255,15,0,0,0,16,0,
36,0,16,0,0,255,255,255,255,255,0,0,255,255,255,255,15,0,0,0,16,0,
47,2,0,
37,
36,0,32,0,0,255,255,255,255,255,1,0,255,255,255,255,15,0,0,0,35,0,
36,0,16,0,0,255,255,255,255,255,1,0,255,255,255,255,15,0,0,0,35,0,
47,3,0,
53,7,0,
37,
36,0,32,0,0,255,255,255,255,255,23,39,255,255,255,255,15,0,0,4,2,0,
36,0,16,0,0,255,255,255,255,255,23,39,255,255,255,255,15,0,0,4,2,0,
47,6,0,0,
24,7,0,0,
24,7,0,1,

2
src/sksl/generated/sksl_rt_shader.dehydrated.sksl
View File

@ -14,7 +14,7 @@ static uint8_t SKSL_INCLUDE_sksl_rt_shader[] = {77,0,
49,8,0,
53,1,0,
37,
36,0,32,0,0,255,255,255,255,255,15,0,255,255,255,255,2,0,0,0,3,0,
36,0,16,0,0,255,255,255,255,255,15,0,255,255,255,255,2,0,0,0,3,0,
50,2,0,16,0,0,
53,3,0,
16,23,0,

8
src/sksl/generated/sksl_vert.dehydrated.sksl
View File

@ -11,10 +11,10 @@ static uint8_t SKSL_INCLUDE_sksl_vert[] = {82,0,
49,6,0,
44,1,0,2,0,2,
37,
36,0,32,0,0,255,255,255,255,255,0,0,255,255,255,255,15,0,0,0,16,0,
36,0,16,0,0,255,255,255,255,255,0,0,255,255,255,255,15,0,0,0,16,0,
50,2,0,28,0,
37,
36,0,32,0,0,255,255,255,255,255,1,0,255,255,255,255,15,0,0,0,35,0,
36,0,16,0,0,255,255,255,255,255,1,0,255,255,255,255,15,0,0,0,35,0,
50,3,0,48,0,
53,4,0,
37,
@ -24,11 +24,11 @@ static uint8_t SKSL_INCLUDE_sksl_vert[] = {82,0,
24,4,0,1,
53,5,0,
37,
36,0,32,0,0,255,255,255,255,255,42,0,255,255,255,255,15,0,0,2,54,0,
36,0,16,0,0,255,255,255,255,255,42,0,255,255,255,255,15,0,0,2,54,0,
50,6,0,66,0,0,
53,7,0,
37,
36,0,32,0,0,255,255,255,255,255,43,0,255,255,255,255,15,0,0,2,70,0,
36,0,16,0,0,255,255,255,255,255,43,0,255,255,255,255,15,0,0,2,70,0,
47,6,0,0,4,0,
5,0,
3,0,

39
tests/sksl/errors/LayoutRepeatedQualifiers.glsl
View File

@ -1,22 +1,21 @@
### Compilation failed:
error: 22: layout qualifier 'origin_upper_left' appears more than once
error: 23: layout qualifier 'override_coverage' appears more than once
error: 24: layout qualifier 'early_fragment_tests' appears more than once
error: 25: layout qualifier 'push_constant' appears more than once
error: 26: layout qualifier 'blend_support_all_equations' appears more than once
error: 27: layout qualifier 'tracked' appears more than once
error: 28: layout qualifier 'srgb_unpremul' appears more than once
error: 29: layout qualifier 'key' appears more than once
error: 30: layout qualifier 'location' appears more than once
error: 31: layout qualifier 'offset' appears more than once
error: 32: layout qualifier 'binding' appears more than once
error: 33: layout qualifier 'index' appears more than once
error: 34: layout qualifier 'set' appears more than once
error: 35: layout qualifier 'builtin' appears more than once
error: 36: layout qualifier 'input_attachment_index' appears more than once
error: 37: layout qualifier 'max_vertices' appears more than once
error: 38: layout qualifier 'invocations' appears more than once
error: 39: layout qualifier 'when' appears more than once
error: 40: layout qualifier 'ctype' appears more than once
19 errors
error: 21: layout qualifier 'origin_upper_left' appears more than once
error: 22: layout qualifier 'override_coverage' appears more than once
error: 23: layout qualifier 'push_constant' appears more than once
error: 24: layout qualifier 'blend_support_all_equations' appears more than once
error: 25: layout qualifier 'tracked' appears more than once
error: 26: layout qualifier 'srgb_unpremul' appears more than once
error: 27: layout qualifier 'key' appears more than once
error: 28: layout qualifier 'location' appears more than once
error: 29: layout qualifier 'offset' appears more than once
error: 30: layout qualifier 'binding' appears more than once
error: 31: layout qualifier 'index' appears more than once
error: 32: layout qualifier 'set' appears more than once
error: 33: layout qualifier 'builtin' appears more than once
error: 34: layout qualifier 'input_attachment_index' appears more than once
error: 35: layout qualifier 'max_vertices' appears more than once
error: 36: layout qualifier 'invocations' appears more than once
error: 37: layout qualifier 'when' appears more than once
error: 38: layout qualifier 'ctype' appears more than once
18 errors