AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed error when normal.z = 1 in GPUs with binary16 floats

Browse Source 
Check failed in GPUs with low-precision floats since 0.9999 was too small a difference from 1 to be detected by a 16-bit float comparison. Changed it to 0.999 which fixed the issue and results in indistinguishable correct behavior.

BUG=skia:5499
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004

Review-Url: https://codereview.chromium.org/2124183004
This commit is contained in:
dvonbeck 2016-07-08 08:59:47 -07:00 committed by Commit bot
parent babc3de2ce
commit 66ad44a3f1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/SkNormalSource.cpp
View File

@ -109,7 +109,7 @@ public:
// transforming all the normals here! // transforming all the normals here!
// If there's no x & y components, return (0, 0, +/- 1) instead to avoid division by 0 // If there's no x & y components, return (0, 0, +/- 1) instead to avoid division by 0
fragBuilder->codeAppend( "if (abs(normal.z) > 0.9999) {"); fragBuilder->codeAppend( "if (abs(normal.z) > 0.999) {");
fragBuilder->codeAppendf(" %s = normalize(vec4(0.0, 0.0, normal.z, 0.0));", fragBuilder->codeAppendf(" %s = normalize(vec4(0.0, 0.0, normal.z, 0.0));",
args.fOutputColor); args.fOutputColor);
// Else, Normalizing the transformed X and Y, while keeping constant both Z and the // Else, Normalizing the transformed X and Y, while keeping constant both Z and the