link with -rdynamic on Linux
This lets our tools get symbols when they backtrace themselves. Here's an example improved stack trace. Notice there are symbols for some Skia methods now. Stack trace: out/Release/dm() [0x5ec19b] out/Release/dm() [0x5ec209] /lib/x86_64-linux-gnu/libc.so.6(+0x36d40) [0x7f6ae0ce2d40] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x39) [0x7f6ae0ce2cc9] /lib/x86_64-linux-gnu/libc.so.6(abort+0x148) [0x7f6ae0ce60d8] out/Release/dm() [0xcd19f9] out/Release/dm() [0x8ca959] out/Release/dm(_ZN11XfermodesGM16onOnceBeforeDrawEv+0x70) [0x8cb640] out/Release/dm(_ZN6skiagm2GM4drawEP8SkCanvas+0x1c) [0x5fc81c] out/Release/dm(_ZNK2DM5GMSrc4drawEP8SkCanvas+0x73) [0x5f3563] out/Release/dm(_ZNK2DM10RasterSink4drawERKNS_3SrcEP8SkBitmapP9SkWStreamP8SkString+0xcc) [0x5f9eac] out/Release/dm(_ZN4Task3RunERKS_+0xd5) [0x5f1685] out/Release/dm() [0xa4d320] out/Release/dm() [0xcb66ba] /lib/x86_64-linux-gnu/libpthread.so.0(+0x8182) [0x7f6ae2667182] /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f6ae0da647d] Today the same crash looks more like this. Stack trace: out/Release/dm() [0x5ec19b] out/Release/dm() [0x5ec209] /lib/x86_64-linux-gnu/libc.so.6(+0x36d40) [0x7f6ae0ce2d40] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x39) [0x7f6ae0ce2cc9] /lib/x86_64-linux-gnu/libc.so.6(abort+0x148) [0x7f6ae0ce60d8] out/Release/dm() [0xcd19f9] out/Release/dm() [0x8ca959] out/Release/dm() [0x8cb640] out/Release/dm() [0x5fc81c] out/Release/dm() [0x5f3563] out/Release/dm() [0x5f9eac] out/Release/dm() [0x5f1685] out/Release/dm() [0xa4d320] out/Release/dm() [0xcb66ba] /lib/x86_64-linux-gnu/libpthread.so.0(+0x8182) [0x7f6ae2667182] /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f6ae0da647d] BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774593002 Review URL: https://codereview.chromium.org/1774593002
This commit is contained in:
parent
d8d046c81f
commit
673748a320
@ -239,6 +239,7 @@
|
||||
'-fno-threadsafe-statics',
|
||||
'-Wnon-virtual-dtor',
|
||||
],
|
||||
'ldflags': [ '-rdynamic' ],
|
||||
'conditions': [
|
||||
[ 'skia_fast', { 'cflags': [ '<@(skia_fast_flags)' ] }],
|
||||
[ 'skia_os != "chromeos"', {
|
||||
|
Loading…
Reference in New Issue
Block a user