AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add threshold for partitioning blur draws

Browse Source 
Change-Id: I67d9fd869871cdcf3c56b2b8e1048095f44c19b0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293337
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
This commit is contained in:
Brian Salomon 2020-06-01 14:52:46 -04:00 committed by Skia Commit-Bot
parent 1adcac52d6
commit 674a5ccd3c
1 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/core/SkGpuBlurUtils.cpp
View File

@ -126,8 +126,6 @@ static std::unique_ptr<GrRenderTargetContext> convolve_gaussian(GrRecordingConte
bool canHWTile =
srcBounds.contains(srcBackingBounds) &&
!(mode == SkTileMode::kDecal && !context->priv().caps()->clampToBorderSupport());
// TODO: Should we also consider size here? If the area where we can avoid shader tiling is
// small this is probably a deoptimization.
if (!canSplit || canHWTile) {
auto dstRect = SkIRect::MakeSize(dstBounds.size());
convolve_gaussian_1d(dstRenderTargetContext.get(), std::move(srcView), srcBounds,
@ -193,6 +191,27 @@ static std::unique_ptr<GrRenderTargetContext> convolve_gaussian(GrRecordingConte
dstRenderTargetContext->priv().clearAtLeast(rect, SK_PMColor4fTRANSPARENT);
};
// Doing mid separately will cause two draws to occur (left and right batch together). At
// small sizes of mid it is worse to issue more draws than to just execute the slightly
// more complicated shader that implements the tile mode across mid. This threshold is
// very arbitrary right now. It is believed that a 21x44 mid on a Moto G4 is a significant
// regression compared to doing one draw but it has not been locally evaluated or tuned.
// The optimal cutoff is likely to vary by GPU.
if (!mid.isEmpty() && mid.width()*mid.height() < 256*256) {
left.join(mid);
left.join(right);
mid = SkIRect::MakeEmpty();
right = SkIRect::MakeEmpty();
// It's unknown whether for kDecal it'd be better to expand the draw rather than a draw and
// up to two clears.
if (mode == SkTileMode::kClamp) {
left.join(top);
left.join(bottom);
top = SkIRect::MakeEmpty();
bottom = SkIRect::MakeEmpty();
}
}
if (!top.isEmpty()) {
if (mode == SkTileMode::kDecal) {
clear(top);