Correct Android.bp warnings.
The gn_to_bp.py script generates projects with is_official_build=true. This means that gn/skia:warnings is not applied. This means that a number of warnings are not turned on, but it also means a number of warnings are not turned off. Directly suppress several warnings which were previously always suppressed. Change-Id: Iefe48f663d47e39f36e21f2200417a33b2389508 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387836 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
This commit is contained in:
parent
22970175f7
commit
72513e7ff6
@ -47,12 +47,15 @@ def GrabDependentValues(js, name, value_type, list_to_extend, exclude):
|
||||
def CleanupCFlags(cflags):
|
||||
# Only use the generated flags related to warnings.
|
||||
cflags = {s for s in cflags if s.startswith('-W')}
|
||||
# Add additional warning suppressions so we can build
|
||||
# third_party/vulkanmemoryallocator
|
||||
# Add additional warning suppressions
|
||||
# Some for third_party/vulkanmemoryallocator
|
||||
# Some for Android's '-Wall -Werror'
|
||||
cflags = cflags.union([
|
||||
"-Wno-implicit-fallthrough",
|
||||
"-Wno-missing-field-initializers",
|
||||
"-Wno-sign-conversion",
|
||||
"-Wno-thread-safety-analysis",
|
||||
"-Wno-unused-parameter",
|
||||
"-Wno-unused-variable",
|
||||
])
|
||||
# Add the rest of the flags we want.
|
||||
|
Loading…
Reference in New Issue
Block a user