From 740e5db7ab58708e64c1eaf19b7fd35eb2f1ad4e Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Mon, 11 Feb 2019 13:19:58 -0500 Subject: [PATCH] remove pointer tagging hack in SkRecord This interferes with other uses of pointer tagging, like ARM pointer authentication or HSWASAN. Bug: b/124135723 Change-Id: I1a78dd4e1b9b18dd02738bb1dfbbb968f29675bc Reviewed-on: https://skia-review.googlesource.com/c/191286 Commit-Queue: Mike Klein Commit-Queue: Leon Scroggins Auto-Submit: Mike Klein Reviewed-by: Leon Scroggins --- src/core/SkRecord.h | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/core/SkRecord.h b/src/core/SkRecord.h index 088975bc16..feabec8b15 100644 --- a/src/core/SkRecord.h +++ b/src/core/SkRecord.h @@ -141,22 +141,20 @@ private: // A typed pointer to some bytes in fAlloc. visit() and mutate() allow polymorphic dispatch. struct Record { - // On 32-bit machines we store type in 4 bytes, followed by a pointer. Simple. - // On 64-bit machines we store a pointer with the type slotted into two top (unused) bytes. - // FWIW, SkRecords::Type is tiny. It can easily fit in one byte. - uint64_t fTypeAndPtr; - static const int kTypeShift = sizeof(void*) == 4 ? 32 : 48; + SkRecords::Type fType; + void* fPtr; // Point this record to its data in fAlloc. Returns ptr for convenience. template T* set(T* ptr) { - fTypeAndPtr = ((uint64_t)T::kType) << kTypeShift | (uintptr_t)ptr; + fType = T::kType; + fPtr = ptr; SkASSERT(this->ptr() == ptr && this->type() == T::kType); return ptr; } - SkRecords::Type type() const { return (SkRecords::Type)(fTypeAndPtr >> kTypeShift); } - void* ptr() const { return (void*)(fTypeAndPtr & ((1ull<