AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove "/" from the generated jUnit method names.

Browse Source 
The "/" character is not a valid character for method names in the
CTS testing environment and is causing problems with some of the
tooling so we are replacing the "/" with "_".

Bug: b/80096930
Change-Id: Icdf790b0975f7c4205153887ffabaaaa85f07592
Reviewed-on: https://skia-review.googlesource.com/129581
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
This commit is contained in:
Derek Sollenberger 2018-05-22 14:19:39 -04:00 committed by Skia Commit-Bot
parent 3de510a20a
commit 749f621376
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
platform_tools/android/apps/skqp/src/main/java/org/skia/skqp/SkQPRunner.java
View File

@ -64,12 +64,12 @@ public class SkQPRunner extends Runner implements Filterable {
for (int backend = 0; backend < impl.mBackends.length; backend++) {
for (int gm = 0; gm < impl.mGMs.length; gm++) {
mTests[index++] = Description.createTestDescription(SkQPRunner.class,
impl.mBackends[backend] + "/" + impl.mGMs[gm]);
impl.mBackends[backend] + "_" + impl.mGMs[gm]);
}
}
for (int unitTest = 0; unitTest < impl.mUnitTests.length; unitTest++) {
mTests[index++] = Description.createTestDescription(SkQPRunner.class,
"unitTest/" + impl.mUnitTests[unitTest]);
"unitTest_" + impl.mUnitTests[unitTest]);
}
assert(index == mTests.length);
mShouldRunTestCount = mTests.length;

2
tools/skqp/gm_knowledge.cpp
View File

@ -297,7 +297,7 @@ static constexpr char kDocHead[] =
"function f(backend, gm, e1, e2) {\n"
" var b = ce(\"div\");\n"
" var x = ce(\"h2\");\n"
" var t = backend + \"/\" + gm;\n"
" var t = backend + \"_\" + gm;\n"
" ac(x, ct(t));\n"
" ac(b, x);\n"
" ac(b, ct(\"backend: \" + backend));\n"