AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove superfluous SkReadBuffer validity checks

Browse Source 
The pattern is to create the spurious object & delete it later

Change-Id: I435e2872127e02c241b5dd27cd965f3c7047a77a
Reviewed-on: https://skia-review.googlesource.com/98783
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
This commit is contained in:
Robert Phillips 2018-01-23 15:17:41 -05:00 committed by Skia Commit-Bot
parent 29b3434e48
commit 757c15402d
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/SkBlurImageFilter.cpp
View File

@ -122,10 +122,6 @@ sk_sp<SkFlattenable> SkBlurImageFilterImpl::CreateProc(SkReadBuffer& buffer) {
static_assert(SkBlurImageFilter::kLast_TileMode == 2, "CreateProc");
if (!buffer.validate(safe)) {
return nullptr;
}
return SkBlurImageFilter::Make(
sigmaX, sigmaY, common.getInput(0), &common.cropRect(), tileMode);
}

8
src/effects/SkLightingImageFilter.cpp
View File

@ -1288,10 +1288,6 @@ sk_sp<SkFlattenable> SkDiffuseLightingImageFilter::CreateProc(SkReadBuffer& buff
SkScalar surfaceScale = buffer.readScalar();
SkScalar kd = buffer.readScalar();
if (!buffer.isValid()) {
return nullptr;
}
return Make(std::move(light), surfaceScale, kd, common.getInput(0), &common.cropRect());
}
@ -1445,10 +1441,6 @@ sk_sp<SkFlattenable> SkSpecularLightingImageFilter::CreateProc(SkReadBuffer& buf
SkScalar ks = buffer.readScalar();
SkScalar shine = buffer.readScalar();
if (!buffer.isValid()) {
return nullptr;
}
return Make(std::move(light), surfaceScale, ks, shine, common.getInput(0),
&common.cropRect());
}