AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't export stage symbols.

Browse Source 
Chromium Mac bots are getting tripped up by stages being visible.
.hidden and .private_extern are -fvisibilty=hidden for ELF and MACH-O.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Mac-Clang-arm-Debug-iOS

Change-Id: I8dbb04f514eead4ab480664f2674db4b57611b84
Reviewed-on: https://skia-review.googlesource.com/10622
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
This commit is contained in:
Mike Klein 2017-03-29 18:21:14 -04:00 committed by Skia Commit-Bot
parent 8f7a9a9bfb
commit 7c4af54b7c
2 changed files with 297 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

287
src/jumper/SkJumper_generated.S
View File

File diff suppressed because it is too large Load Diff

12
src/jumper/build_stages.py
View File

@ -72,9 +72,9 @@ subprocess.check_call(clang + cflags + vfp4 +
['-o', 'vfp4.o'])
def parse_object_file(dot_o, directive, target=None):
globl, label, comment = '.globl', ':', '// '
globl, hidden, label, comment = '.globl', 'HIDDEN', ':', '// '
if 'win' in dot_o:
globl, label, comment = 'PUBLIC', ' LABEL PROC', '; '
globl, hidden, label, comment = 'PUBLIC', '', ' LABEL PROC', '; '
dehex = lambda h: '0x'+h
if directive != '.long':
@ -103,6 +103,8 @@ def parse_object_file(dot_o, directive, target=None):
m = re.match('''[0-9a-f]+ <_?(.*)>:''', line)
if m:
print
if hidden:
print hidden + ' _' + m.group(1)
print globl + ' _' + m.group(1)
print '_' + m.group(1) + label
continue
@ -132,6 +134,12 @@ print '''# Copyright 2017 Google Inc.
# This file is generated semi-automatically with this command:
# $ src/jumper/build_stages.py
'''
print '#if defined(__MACH__)'
print ' #define HIDDEN .private_extern'
print '#else'
print ' #define HIDDEN .hidden'
print '#endif'
print '.text'
print '#if defined(__aarch64__)'
print '.balign 4'