AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Mark SkPictureRecorder::endRecording as SK_WARN_UNUSED_RESULT.

Browse Source 
Ignoring the result is a memory leak.
Callers should always at least unref the result.

This bug has occurred in Blink:
  https://codereview.chromium.org/1068413002/

BUG=skia:3680

Review URL: https://codereview.chromium.org/1072633002
This commit is contained in:
jbroman 2015-04-09 06:12:17 -07:00 committed by Commit bot
parent d9f8862ab6
commit 7d1b945da6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/core/SkPictureRecorder.h
View File

@ -67,7 +67,7 @@ public:
* reflect their current state, but will not contain a live reference to the drawables
* themselves.
*/
SkPicture* endRecordingAsPicture();
SkPicture* SK_WARN_UNUSED_RESULT endRecordingAsPicture();
/**
* Signal that the caller is done recording. This invalidates the canvas returned by
@ -79,10 +79,10 @@ public:
* and therefore this drawable will reflect the current state of those nested drawables anytime
* it is drawn or a new picture is snapped from it (by calling drawable->newPictureSnapshot()).
*/
SkDrawable* endRecordingAsDrawable();
SkDrawable* SK_WARN_UNUSED_RESULT endRecordingAsDrawable();
// Legacy API -- use endRecordingAsPicture instead.
SkPicture* endRecording() { return this->endRecordingAsPicture(); }
SkPicture* SK_WARN_UNUSED_RESULT endRecording() { return this->endRecordingAsPicture(); }
private:
void reset();