SKIA_IMPLEMENTATION is only relevant in shared builds

Change-Id: If4ce780a74d59e5ec5c9d950a560527d4de7e030
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/210130
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
This commit is contained in:
Mike Klein 2019-04-24 12:42:08 -05:00 committed by Skia Commit-Bot
parent 2253c22afb
commit 8413ff13fe
2 changed files with 3 additions and 2 deletions

View File

@ -165,7 +165,9 @@ config("skia_private") {
# Any code that's linked into Skia-the-library should use this config via += skia_library_configs.
config("skia_library") {
visibility = [ ":*" ]
defines = [ "SKIA_IMPLEMENTATION=1" ]
if (is_component_build) {
defines = [ "SKIA_IMPLEMENTATION=1" ]
}
}
skia_library_configs = [

View File

@ -103,7 +103,6 @@ def GetArchSources(opts_file):
def WriteUserConfig(userConfigPath, defines):
# Most defines go into SkUserConfig.h
defines.remove('NDEBUG') # Controlled by the Android build
defines.remove('SKIA_IMPLEMENTATION=1') # don't export this define.
if 'WIN32_LEAN_AND_MEAN' in defines: # Controlled by the Android build
defines.remove('WIN32_LEAN_AND_MEAN')
if '_HAS_EXCEPTIONS=0' in defines: # Controlled by the Android build