AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Revert "Take missed opportunity: memset for A8.""

Browse Source 
This reverts commit 2028625f9b.

Reason for revert: not the reason for broken roll.

Original change's description:
> Revert "Take missed opportunity: memset for A8."
> 
> This reverts commit 9cee33e631.
> 
> Reason for revert: Chrome roll?
> 
> Original change's description:
> > Take missed opportunity: memset for A8.
> > 
> > Just recently noticed we weren't doing this.
> > It seems to be triggering all the time.
> > 
> > Draws the same of course.
> > 
> > Change-Id: Ie3d869a05194a5d52d635643eba1c96c8a21ce67
> > Reviewed-on: https://skia-review.googlesource.com/8471
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Mike Klein <mtklein@chromium.org>
> > 
> 
> TBR=mtklein@chromium.org,msarett@google.com,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Change-Id: I26a3f2b1a9ae9093180e9c5cc61094b239377c17
> Reviewed-on: https://skia-review.googlesource.com/8606
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> 

TBR=mtklein@chromium.org,msarett@google.com,reed@google.com
NOPRESUBMIT=true

Change-Id: Ib14360c6669abf9dd0c5bd152773b314d094fe72
Reviewed-on: https://skia-review.googlesource.com/8617
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
This commit is contained in:
Mike Klein 2017-02-17 16:10:46 +00:00 committed by Skia Commit-Bot
parent 02241e976b
commit 86125483f9
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/core/SkRasterPipelineBlitter.cpp
View File

@ -224,16 +224,10 @@ void SkRasterPipelineBlitter::blitH(int x, int y, int w) {
if (fCanMemsetInBlitH) {
switch (fDst.shiftPerPixel()) {
// TODO: case 0: memset (for A8)
case 1:
sk_memset16((uint16_t*)fDstPtr + x, fMemsetColor, w);
return;
case 2:
sk_memset32((uint32_t*)fDstPtr + x, fMemsetColor, w);
return;
case 3:
sk_memset64((uint64_t*)fDstPtr + x, fMemsetColor, w);
return;
case 0: memset ((uint8_t *)fDstPtr + x, fMemsetColor, w); return;
case 1: sk_memset16((uint16_t*)fDstPtr + x, fMemsetColor, w); return;
case 2: sk_memset32((uint32_t*)fDstPtr + x, fMemsetColor, w); return;
case 3: sk_memset64((uint64_t*)fDstPtr + x, fMemsetColor, w); return;
default: break;
}
}