AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Always keep buffers in vulkan persistently mapped.

Browse Source 
This should hopefully fix (and possibly even improve) some of the perf
regressions we had form switching the memory allocator which were caused
by us now mapping and unmapping the entire VkDeviceMemory instead of just
subsets.

Bug: skia:
Change-Id: Ia8232594f33003e88969bf16febea4e4eec0ac95
Reviewed-on: https://skia-review.googlesource.com/131443
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
This commit is contained in:
Greg Daniel 2018-06-01 13:35:16 -04:00 committed by Skia Commit-Bot
parent d2ae8dcce3
commit 8683037a2e
3 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/gpu/vk/GrVkMemoryAllocator.h
View File

@ -28,7 +28,7 @@ public:
// The allocation will be mapped immediately and stay mapped until it is destroyed. This
// flag is only valid for buffers which are host visible (i.e. must have a usage other than
// BufferUsage::kGpuOnly).
kPersistentlyMapped = 0x3,
kPersistentlyMapped = 0x4,
};
GR_DECL_BITFIELD_CLASS_OPS_FRIENDS(AllocationPropertyFlags);

3
src/gpu/vk/GrVkAMDMemoryAllocator.cpp
View File

@ -130,7 +130,8 @@ bool GrVkAMDMemoryAllocator::allocateMemoryForBuffer(VkBuffer buffer, BufferUsag
info.preferredFlags |= VK_MEMORY_PROPERTY_LAZILY_ALLOCATED_BIT;
}
if ((AllocationPropertyFlags::kPersistentlyMapped & flags) && BufferUsage::kGpuOnly != usage) {
if (AllocationPropertyFlags::kPersistentlyMapped & flags) {
SkASSERT(BufferUsage::kGpuOnly != usage);
info.flags |= VMA_ALLOCATION_CREATE_MAPPED_BIT;
}

19
src/gpu/vk/GrVkMemory.cpp
View File

@ -41,8 +41,23 @@ bool GrVkMemory::AllocAndBindBufferMemory(const GrVkGpu* gpu,
GrVkMemoryAllocator::BufferUsage usage = get_buffer_usage(type, dynamic);
if (!allocator->allocateMemoryForBuffer(buffer, usage, AllocationPropertyFlags::kNone,
&memory)) {
AllocationPropertyFlags propFlags;
if (usage == GrVkMemoryAllocator::BufferUsage::kCpuWritesGpuReads) {
// In general it is always fine (and often better) to keep buffers always mapped.
// TODO: According to AMDs guide for the VulkanMemoryAllocator they suggest there are two
// cases when keeping it mapped can hurt. The first is when running on Win7 or Win8 (Win 10
// is fine). In general, by the time Vulkan ships it is probably less likely to be running
// on non Win10 or newer machines. The second use case is if running on an AMD card and you
// are using the special GPU local and host mappable memory. However, in general we don't
// pick this memory as we've found it slower than using the cached host visible memory. In
// the future if we find the need to special case either of these two issues we can add
// checks for them here.
propFlags = AllocationPropertyFlags::kPersistentlyMapped;
} else {
propFlags = AllocationPropertyFlags::kNone;
}
if (!allocator->allocateMemoryForBuffer(buffer, usage, propFlags, &memory)) {
return false;
}
allocator->getAllocInfo(memory, alloc);