AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable NEON procs for box blur as it produces invalid results

Browse Source 
R=reed@google.com, mtklein@google.com, senorblanco@google.com
TBR=reed@google.com
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/527973002
This commit is contained in:
djsollen 2014-09-02 08:57:39 -07:00 committed by Commit bot
parent 6db9128efb
commit 871dca8ea9
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
expectations/gm/ignored-tests.txt
View File

@ -44,3 +44,15 @@ matrixconvolution
# Added as part of https://codereview.chromium.org/466363009/
fontcache
# fix broken blurs on android (djsollen)
# http://skbug.com/2845
imageblur
imageblur2
imagefiltersbase
imagefiltersclipped
imagefilterscropped
imagefiltersgraph
imagefiltersscaled
spritebitmap
testimagefilters

5
src/opts/SkBlurImage_opts_arm.cpp
View File

@ -12,10 +12,11 @@ bool SkBoxBlurGetPlatformProcs(SkBoxBlurProc* boxBlurX,
SkBoxBlurProc* boxBlurY,
SkBoxBlurProc* boxBlurXY,
SkBoxBlurProc* boxBlurYX) {
// Temporary workaround for http://skbug.com/2845
return false;
#if SK_ARM_NEON_IS_NONE
return false;
#elif defined(SK_CPU_ARM64) // Temporary fix for
return false; // http://skbug.com/2845
#else
#if SK_ARM_NEON_IS_DYNAMIC
if (!sk_cpu_arm_has_neon()) {