AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

webtry: Do not forget the close the rows.

Browse Source 
This should prevent further enumeration according to the docs.

http://golang.org/pkg/database/sql/#Rows.Close

BUG=None
TEST=None
R=humper@google.com

Review URL: https://codereview.chromium.org/638373003
This commit is contained in:
tfarina 2014-10-16 05:57:39 -07:00 committed by Commit bot
parent ff58e4679b
commit 8c0d2aab62
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
experimental/webtry/webtry.go
View File

@ -303,11 +303,11 @@ func init() {
func writeOutAllSourceImages() {
// Pull all the source images from the db and write them out to inout.
rows, err := db.Query("SELECT id, image, create_ts FROM source_images ORDER BY create_ts DESC")
if err != nil {
glog.Errorf("Failed to open connection to SQL server: %q\n", err)
panic(err)
}
defer rows.Close()
for rows.Next() {
var id int
var image []byte
@ -478,10 +478,10 @@ func sourcesHandler(w http.ResponseWriter, r *http.Request) {
glog.Infof("Sources Handler: %q\n", r.URL.Path)
if r.Method == "GET" {
rows, err := db.Query("SELECT id, create_ts FROM source_images WHERE hidden=0 ORDER BY create_ts DESC")
if err != nil {
http.Error(w, fmt.Sprintf("Failed to query sources: %s.", err), 500)
}
defer rows.Close()
sources := make([]Sources, 0, 0)
for rows.Next() {
var id int
@ -577,12 +577,12 @@ type Recent struct {
func recentHandler(w http.ResponseWriter, r *http.Request) {
glog.Infof("Recent Handler: %q\n", r.URL.Path)
var err error
rows, err := db.Query("SELECT create_ts, hash FROM webtry ORDER BY create_ts DESC LIMIT 20")
if err != nil {
http.NotFound(w, r)
return
}
defer rows.Close()
recent := []Try{}
for rows.Next() {
var hash string
@ -654,6 +654,7 @@ func workspaceHandler(w http.ResponseWriter, r *http.Request) {
reportError(w, r, err, "Failed to select.")
return
}
defer rows.Close()
for rows.Next() {
var hash string
var create_ts time.Time