AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add parameter names to FunctionDeclaration descriptions.

Browse Source 
Separating this out from landing SkSL DSL, as it's causing unrelated
test churn as the DSL code gets submitted and reverted.

Change-Id: I0d3ade4ca8d1b0c302ccc494f0192a4f5ae67086
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/343109
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
This commit is contained in:
John Stiles 2020-12-10 18:00:55 -05:00 committed by Skia Commit-Bot
parent f7cce2b243
commit 90227be1bf
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/sksl/ir/SkSLFunctionDeclaration.h
View File

@ -68,6 +68,8 @@ public:
result += separator;
separator = ", ";
result += p->type().displayName();
result += " ";
result += p->name();
}
result += ")";
return result;

4
tests/sksl/intrinsics/golden/MatrixCompMult.asm.frag
View File

@ -1,5 +1,5 @@
### Compilation failed:
error: 4: unsupported intrinsic '$matH matrixCompMult($matH, $matH)'
error: 5: unsupported intrinsic '$mat matrixCompMult($mat, $mat)'
error: 4: unsupported intrinsic '$matH matrixCompMult($matH x, $matH y)'
error: 5: unsupported intrinsic '$mat matrixCompMult($mat x, $mat y)'
2 errors