From 9442ab8a40dd0effde253e3b2d166bcf47222e92 Mon Sep 17 00:00:00 2001 From: benjaminwagner Date: Thu, 1 Oct 2015 16:25:51 -0700 Subject: [PATCH] Reland of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1382933002/ ) Reason for revert: Not fixed. :-( Original issue's description: > Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1365683003/ ) > > Reason for revert: > should hopefully be fixed, please reland if not. > > Original issue's description: > > Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 > > > > BUG=skia:4373 > > > > Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47 > > TBR=borenet@google.com,benjaminwagner@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:4373 > > Committed: https://skia.googlesource.com/skia/+/52f8deba607fd67558b57551cd43406c8b743072 TBR=borenet@google.com,joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4373 Review URL: https://codereview.chromium.org/1375733003 --- tools/nanobench_flags.json | 4 +++- tools/nanobench_flags.py | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/nanobench_flags.json b/tools/nanobench_flags.json index 6084ad1609..049bf543fd 100644 --- a/tools/nanobench_flags.json +++ b/tools/nanobench_flags.json @@ -49,7 +49,9 @@ "~blurroundrect", "~patch_grid", "~desk_carsvg", - "~GLInstancedArraysBench" + "~GLInstancedArraysBench", + "~GLVertexAttributesBench", + "~GLVec4ScalarBench" ], "Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind": [ "--scales", diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py index f11ea1f0f1..86d720356d 100755 --- a/tools/nanobench_flags.py +++ b/tools/nanobench_flags.py @@ -69,6 +69,8 @@ def get_args(bot): match.append('~desk_unicodetable') if 'GalaxyS4' in bot: match.append('~GLInstancedArraysBench') # skia:4371 + # skia:4373 + match.extend(['~GLVertexAttributesBench', '~GLVec4ScalarBench']) if 'iOS' in bot: match.append('~blurroundrect')