AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[skottie-wasm-perf] Add retries when calling puppeteer

Browse Source 
NoTry: true
Bug: skia:9207
Change-Id: I8ff9d2211a268a2564b5752e7a72429380f007ce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223936
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
This commit is contained in:
Ravi Mistry 2019-06-26 14:52:31 +00:00 committed by Skia Commit-Bot
parent d6b53d54cb
commit 9dbbf887ce
5 changed files with 55 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
infra/bots/recipes/perf_skottiewasm_lottieweb.expected/lottie_web_perf.json
View File

@ -136,6 +136,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie1.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/lottie-web-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app"
},
@ -163,6 +167,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie2.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/lottie-web-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app (2)"
},
@ -190,6 +198,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie3.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/lottie-web-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app (3)"
},

12
infra/bots/recipes/perf_skottiewasm_lottieweb.expected/lottie_web_perf_trybot.json
View File

@ -138,6 +138,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie1.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/lottie-web-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app"
},
@ -165,6 +169,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie2.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/lottie-web-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app (2)"
},
@ -192,6 +200,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie3.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/lottie-web-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app (3)"
},

12
infra/bots/recipes/perf_skottiewasm_lottieweb.expected/skottie_wasm_perf.json
View File

@ -140,6 +140,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie1.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/skottie-wasm-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app"
},
@ -171,6 +175,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie2.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/skottie-wasm-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app (2)"
},
@ -202,6 +210,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie3.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/skottie-wasm-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app (3)"
},

12
infra/bots/recipes/perf_skottiewasm_lottieweb.expected/skottie_wasm_perf_trybot.json
View File

@ -142,6 +142,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie1.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/skottie-wasm-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app"
},
@ -173,6 +177,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie2.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/skottie-wasm-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app (2)"
},
@ -204,6 +212,10 @@
"[CLEANUP]/g3_try_tmp_1/lottie3.json"
],
"cwd": "[START_DIR]/cache/work/skia/tools/skottie-wasm-perf",
"env": {
"CHROME_HEADLESS": "1",
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "Run perf cmd line app (3)"
},

11
infra/bots/recipes/perf_skottiewasm_lottieweb.py
View File

@ -89,11 +89,14 @@ def RunSteps(api):
continue
output_file = output_dir.join(lottie_filename)
with api.context(cwd=perf_app_dir):
# This is occasionally flaky due to skbug.com/9207, adding retries.
attempts = 3
# Add output and input arguments to the cmd.
api.step('Run perf cmd line app', cmd=perf_app_cmd + [
'--input', lottie_file,
'--output', output_file,
], infra_step=True)
api.run.with_retry(api.step, 'Run perf cmd line app', attempts,
cmd=perf_app_cmd + [
'--input', lottie_file,
'--output', output_file,
], infra_step=True)
output_json = api.file.read_json(
'Read perf json', output_file,
test_data={'frame_avg_us': 185.79982221126556,