AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add a "[DO NOT SUBMIT]" prefix to the uploaded Android change

Browse Source 
Since the script cannot do anything to prevent submission via the API it might
help to atleast add a "[DO NOT SUBMIT]" prefix.

NoTry: true
Bug: skia:7016
Change-Id: I825f28947df85a4d54ead764f8d363e12f83fbfb
Reviewed-on: https://skia-review.googlesource.com/44840
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
This commit is contained in:
Ravi Mistry 2017-09-11 11:00:34 -04:00 committed by Skia Commit-Bot
parent 6a7a704aa4
commit a2bdf005f3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/android/upload_to_android.py
View File

@ -121,11 +121,12 @@ About to run repo init. If it hangs asking you to run glogin then please:
shell=True)
subprocess.check_call('git cherry-pick FETCH_HEAD', shell=True)
# Amend the commit message to add "Test:" which is required by Android
# presubmit checks.
# Amend the commit message to add a "[DO NOT SUBMIT]" prefix and a "Test:"
# line which is required by Android presubmit checks.
original_commit_message = change_details['subject']
new_commit_message = (
"%s\n\nTest: Presubmit checks will test this change." % (
'[DO NOT SUBMIT] %s\n\n'
'Test: Presubmit checks will test this change.' % (
original_commit_message))
subprocess.check_call('git commit --amend -m "%s"' % new_commit_message,
shell=True)