Move SkSpan to include/, for use in public API

Change-Id: I674f038600afd6d49316c1ece515941ee5579068
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/406939
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

fuzz/FuzzSkParagraph.cpp

@@ -19,6 +19,7 @@
 #include "include/core/SkRect.h"
 #include "include/core/SkRefCnt.h"
 #include "include/core/SkScalar.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkStream.h"
 #include "include/core/SkString.h"
 #include "include/core/SkTypeface.h"
@@ -37,7 +38,6 @@
 #include "modules/skparagraph/src/TextLine.h"
 #include "modules/skparagraph/utils/TestFontCollection.h"
 #include "src/core/SkOSFile.h"
-#include "src/core/SkSpan.h"
 #include "src/utils/SkOSPath.h"
 #include "src/utils/SkShaperJSONWriter.h"
 #include "tests/Test.h"

gm/drawglyphs.cpp

@@ -10,8 +10,8 @@
 #include "include/core/SkFont.h"
 #include "include/core/SkPaint.h"
 #include "include/core/SkRSXform.h"
+#include "include/core/SkSpan.h"
 #include "include/private/SkTDArray.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkZip.h"
 #include "tools/ToolUtils.h"
 

include/core/SkSpan.h

@@ -15,6 +15,10 @@
 #include "include/private/SkTLogic.h"
 
 /**
+ * An SkSpan is a view of a contiguous collection of elements of type T. It can be directly
+ * constructed from a pointer and size. SkMakeSpan can be used to construct one from an array,
+ * or a container (like std::vector).
+ *
  * With C++17, we could add template deduction guides that eliminate the need for SkMakeSpan:
  *     https://skia-review.googlesource.com/c/skia/+/320264
  */

modules/skparagraph/src/Iterators.h

@@ -2,11 +2,11 @@
 #ifndef FontIterator_DEFINED
 #define FontIterator_DEFINED
 
+#include "include/core/SkSpan.h"
 #include "include/core/SkString.h"
 #include "include/core/SkTypes.h"
 #include "modules/skparagraph/include/TextStyle.h"
 #include "modules/skshaper/include/SkShaper.h"
-#include "src/core/SkSpan.h"
 
 namespace skia {
 namespace textlayout {

modules/skparagraph/src/OneLineShaper.h

@@ -4,10 +4,10 @@
 
 #include <functional>  // std::function
 #include <queue>
+#include "include/core/SkSpan.h"
 #include "modules/skparagraph/include/TextStyle.h"
 #include "modules/skparagraph/src/ParagraphImpl.h"
 #include "modules/skparagraph/src/Run.h"
-#include "src/core/SkSpan.h"
 
 namespace skia {
 namespace textlayout {

modules/skparagraph/src/ParagraphImpl.cpp

@@ -4,6 +4,7 @@
 #include "include/core/SkFontMetrics.h"
 #include "include/core/SkMatrix.h"
 #include "include/core/SkPictureRecorder.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkTypeface.h"
 #include "include/private/SkTFitsIn.h"
 #include "include/private/SkTo.h"
@@ -16,7 +17,6 @@
 #include "modules/skparagraph/src/Run.h"
 #include "modules/skparagraph/src/TextLine.h"
 #include "modules/skparagraph/src/TextWrapper.h"
-#include "src/core/SkSpan.h"
 #include "src/utils/SkUTF.h"
 #include <math.h>
 #include <algorithm>

modules/skparagraph/src/ParagraphImpl.h

@@ -9,6 +9,7 @@
 #include "include/core/SkRect.h"
 #include "include/core/SkRefCnt.h"
 #include "include/core/SkScalar.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkString.h"
 #include "include/core/SkTypes.h"
 #include "include/private/SkBitmaskEnum.h"
@@ -25,7 +26,6 @@
 #include "modules/skparagraph/src/Run.h"
 #include "modules/skparagraph/src/TextLine.h"
 #include "modules/skshaper/src/SkUnicode.h"
-#include "src/core/SkSpan.h"
 
 #include <memory>
 #include <string>

modules/skparagraph/src/Run.h

@@ -7,12 +7,12 @@
 #include "include/core/SkPoint.h"
 #include "include/core/SkRect.h"
 #include "include/core/SkScalar.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkTypes.h"
 #include "include/private/SkTArray.h"
 #include "modules/skparagraph/include/DartTypes.h"
 #include "modules/skparagraph/include/TextStyle.h"
 #include "modules/skshaper/include/SkShaper.h"
-#include "src/core/SkSpan.h"
 
 #include <math.h>
 #include <algorithm>

modules/skparagraph/src/TextLine.cpp

@@ -5,6 +5,7 @@
 #include "include/core/SkFontMetrics.h"
 #include "include/core/SkMaskFilter.h"
 #include "include/core/SkPaint.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkString.h"
 #include "include/core/SkTextBlob.h"
 #include "include/core/SkTypes.h"
@@ -19,7 +20,6 @@
 #include "modules/skparagraph/src/ParagraphImpl.h"
 #include "modules/skparagraph/src/TextLine.h"
 #include "modules/skshaper/include/SkShaper.h"
-#include "src/core/SkSpan.h"
 
 #include <algorithm>
 #include <iterator>

modules/skparagraph/src/TextWrapper.h

@@ -3,8 +3,8 @@
 #define TextWrapper_DEFINED
 
 #include <string>
+#include "include/core/SkSpan.h"
 #include "modules/skparagraph/src/TextLine.h"
-#include "src/core/SkSpan.h"
 
 namespace skia {
 namespace textlayout {

modules/skparagraph/tests/SkParagraphTest.cpp

@@ -11,6 +11,7 @@
 #include "include/core/SkRect.h"
 #include "include/core/SkRefCnt.h"
 #include "include/core/SkScalar.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkStream.h"
 #include "include/core/SkString.h"
 #include "include/core/SkTypeface.h"
@@ -29,7 +30,6 @@
 #include "modules/skparagraph/src/TextLine.h"
 #include "modules/skparagraph/utils/TestFontCollection.h"
 #include "src/core/SkOSFile.h"
-#include "src/core/SkSpan.h"
 #include "src/utils/SkOSPath.h"
 #include "src/utils/SkShaperJSONWriter.h"
 #include "tests/Test.h"

modules/skshaper/src/SkShaper_harfbuzz.cpp

@@ -15,6 +15,7 @@
 #include "include/core/SkRect.h"
 #include "include/core/SkRefCnt.h"
 #include "include/core/SkScalar.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkStream.h"
 #include "include/core/SkTypeface.h"
 #include "include/core/SkTypes.h"
@@ -28,7 +29,6 @@
 #include "modules/skshaper/include/SkShaper.h"
 #include "modules/skshaper/src/SkUnicode.h"
 #include "src/core/SkLRUCache.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkTDPQueue.h"
 #include "src/utils/SkUTF.h"
 

modules/skshaper/src/SkUnicode.h

@@ -7,8 +7,8 @@
 #ifndef SkUnicode_DEFINED
 #define SkUnicode_DEFINED
 
+#include "include/core/SkSpan.h"
 #include "include/core/SkTypes.h"
-#include "src/core/SkSpan.h"
 #include "src/utils/SkUTF.h"
 #include <vector>
 

src/core/SkGlyphRun.h

@@ -15,9 +15,9 @@
 #include "include/core/SkPaint.h"
 #include "include/core/SkPoint.h"
 #include "include/core/SkRSXform.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkTypes.h"
 #include "include/private/SkTemplates.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkZip.h"
 
 class SkBaseDevice;

src/core/SkRemoteGlyphCache.cpp

@@ -15,6 +15,7 @@
 #include <tuple>
 
 #include "include/core/SkSerialProcs.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkTypeface.h"
 #include "include/private/SkChecksum.h"
 #include "include/private/SkTHash.h"
@@ -23,7 +24,6 @@
 #include "src/core/SkEnumerate.h"
 #include "src/core/SkGlyphRun.h"
 #include "src/core/SkScalerCache.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkStrikeCache.h"
 #include "src/core/SkStrikeForGPU.h"
 #include "src/core/SkTLazy.h"

src/core/SkStrikeForGPU.h

@@ -10,9 +10,9 @@
 
 #include "include/core/SkPaint.h"
 #include "include/core/SkPoint.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkTypes.h"
 #include "src/core/SkGlyph.h"
-#include "src/core/SkSpan.h"
 
 #include <memory>
 

src/core/SkVM.h

@@ -10,10 +10,10 @@
 
 #include "include/core/SkBlendMode.h"
 #include "include/core/SkColor.h"
+#include "include/core/SkSpan.h"
 #include "include/private/SkMacros.h"
 #include "include/private/SkTArray.h"
 #include "include/private/SkTHash.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkVM_fwd.h"
 #include <vector>      // std::vector
 

src/core/SkZip.h

@@ -13,10 +13,10 @@
 #include <type_traits>
 #include <utility>
 
+#include "include/core/SkSpan.h"
 #include "include/core/SkTypes.h"
 #include "include/private/SkTemplates.h"
 #include "include/private/SkTo.h"
-#include "src/core/SkSpan.h"
 
 // Take a list of things that can be pointers, and use them all in parallel. The iterators and
 // accessor operator[] for the class produce a tuple of the items.

src/gpu/GrDirectContextPriv.h

@@ -8,9 +8,9 @@
 #ifndef GrDirectContextPriv_DEFINED
 #define GrDirectContextPriv_DEFINED
 
+#include "include/core/SkSpan.h"
 #include "include/core/SkSurface.h"
 #include "include/gpu/GrDirectContext.h"
-#include "src/core/SkSpan.h"
 
 class GrAtlasManager;
 class GrBackendFormat;

src/gpu/GrDrawingManager.h

@@ -8,10 +8,10 @@
 #ifndef GrDrawingManager_DEFINED
 #define GrDrawingManager_DEFINED
 
+#include "include/core/SkSpan.h"
 #include "include/core/SkSurface.h"
 #include "include/private/SkTArray.h"
 #include "include/private/SkTHash.h"
-#include "src/core/SkSpan.h"
 #include "src/gpu/GrBufferAllocPool.h"
 #include "src/gpu/GrDeferredUpload.h"
 #include "src/gpu/GrHashMapWithCache.h"

src/gpu/GrGpu.h

@@ -9,10 +9,10 @@
 #define GrGpu_DEFINED
 
 #include "include/core/SkPath.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkSurface.h"
 #include "include/gpu/GrTypes.h"
 #include "include/private/SkTArray.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkTInternalLList.h"
 #include "src/gpu/GrAttachment.h"
 #include "src/gpu/GrCaps.h"

src/gpu/GrOnFlushResourceProvider.h

@@ -9,8 +9,8 @@
 #define GrOnFlushResourceProvider_DEFINED
 
 #include "include/core/SkRefCnt.h"
+#include "include/core/SkSpan.h"
 #include "include/private/SkTArray.h"
-#include "src/core/SkSpan.h"
 #include "src/gpu/GrDeferredUpload.h"
 #include "src/gpu/GrOpFlushState.h"
 #include "src/gpu/GrResourceProvider.h"

src/gpu/GrOpsTask.h

@@ -10,6 +10,7 @@
 
 #include "include/core/SkMatrix.h"
 #include "include/core/SkRefCnt.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkStrokeRec.h"
 #include "include/core/SkTypes.h"
 #include "include/gpu/GrRecordingContext.h"
@@ -17,7 +18,6 @@
 #include "include/private/SkTDArray.h"
 #include "src/core/SkArenaAlloc.h"
 #include "src/core/SkClipStack.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkStringUtils.h"
 #include "src/core/SkTLazy.h"
 #include "src/gpu/GrAppliedClip.h"

src/gpu/GrRenderTaskCluster.h

@@ -9,7 +9,7 @@
 #define GrRenderTaskCluster_DEFINED
 
 #include "include/core/SkRefCnt.h"
-#include "src/core/SkSpan.h"
+#include "include/core/SkSpan.h"
 #include "src/core/SkTInternalLList.h"
 
 class GrRenderTask;

src/gpu/GrSubRunAllocator.h

@@ -8,8 +8,8 @@
 #ifndef GrSubRunAllocator_DEFINED
 #define GrSubRunAllocator_DEFINED
 
+#include "include/core/SkSpan.h"
 #include "src/core/SkArenaAlloc.h"
-#include "src/core/SkSpan.h"
 
 #include <algorithm>
 #include <memory>

src/gpu/glsl/GrGLSLShaderBuilder.h

@@ -8,10 +8,10 @@
 #ifndef GrGLSLShaderBuilder_DEFINED
 #define GrGLSLShaderBuilder_DEFINED
 
+#include "include/core/SkSpan.h"
 #include "include/private/SkSLStatement.h"
 #include "include/private/SkSLString.h"
 #include "include/private/SkTDArray.h"
-#include "src/core/SkSpan.h"
 #include "src/gpu/GrShaderVar.h"
 #include "src/gpu/GrTBlockList.h"
 #include "src/gpu/glsl/GrGLSLUniformHandler.h"

src/gpu/ops/GrAtlasTextOp.cpp

@@ -8,11 +8,11 @@
 #include "src/gpu/ops/GrAtlasTextOp.h"
 
 #include "include/core/SkPoint3.h"
+#include "include/core/SkSpan.h"
 #include "include/gpu/GrRecordingContext.h"
 #include "src/core/SkMathPriv.h"
 #include "src/core/SkMatrixPriv.h"
 #include "src/core/SkMatrixProvider.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkStrikeCache.h"
 #include "src/gpu/GrCaps.h"
 #include "src/gpu/GrMemoryPool.h"

src/sksl/SkSLDehydrator.h

@@ -10,10 +10,10 @@
 
 #ifdef SKSL_STANDALONE
 
+#include "include/core/SkSpan.h"
 #include "include/private/SkSLModifiers.h"
 #include "include/private/SkSLSymbol.h"
 #include "include/private/SkTHash.h"
-#include "src/core/SkSpan.h"
 #include "src/sksl/SkSLOutputStream.h"
 #include "src/sksl/SkSLStringStream.h"
 

src/sksl/codegen/SkSLVMCodeGenerator.h

@@ -8,8 +8,8 @@
 #ifndef SKSL_VMGENERATOR
 #define SKSL_VMGENERATOR
 
+#include "include/core/SkSpan.h"
 #include "include/private/SkSLString.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkVM.h"
 #include "src/sksl/ir/SkSLType.h"
 

src/sksl/ir/SkSLConstructor.h

@@ -8,7 +8,7 @@
 #ifndef SKSL_CONSTRUCTOR
 #define SKSL_CONSTRUCTOR
 
-#include "src/core/SkSpan.h"
+#include "include/core/SkSpan.h"
 #include "src/sksl/SkSLIRGenerator.h"
 #include "src/sksl/ir/SkSLExpression.h"
 

src/utils/SkShaperJSONWriter.h

@@ -14,8 +14,8 @@
 #include <string>
 #include <vector>
 
+#include "include/core/SkSpan.h"
 #include "modules/skshaper/include/SkShaper.h"
-#include "src/core/SkSpan.h"
 
 class SkJSONWriter;
 

tests/ResourceAllocatorTest.cpp

@@ -6,9 +6,9 @@
  */
 
 #include "include/core/SkCanvas.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkSurface.h"
 #include "include/gpu/GrDirectContext.h"
-#include "src/core/SkSpan.h"
 #include "src/gpu/GrDirectContextPriv.h"
 #include "src/gpu/GrGpu.h"
 #include "src/gpu/GrProxyProvider.h"

tests/SkShaperJSONWriterTest.cpp

@@ -9,7 +9,7 @@
 
 #include "tests/Test.h"
 
-#include "src/core/SkSpan.h"
+#include "include/core/SkSpan.h"
 #include "src/utils/SkJSONWriter.h"
 #include "src/utils/SkUTF.h"
 

tests/UtilsTest.cpp

@@ -6,9 +6,9 @@
  */
 
 #include "include/core/SkRefCnt.h"
+#include "include/core/SkSpan.h"
 #include "include/utils/SkRandom.h"
 #include "src/core/SkEnumerate.h"
-#include "src/core/SkSpan.h"
 #include "src/core/SkTSearch.h"
 #include "src/core/SkTSort.h"
 #include "src/core/SkZip.h"

tools/DDLTileHelper.h

@@ -11,8 +11,8 @@
 #include "include/core/SkDeferredDisplayList.h"
 #include "include/core/SkRect.h"
 #include "include/core/SkRefCnt.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkSurfaceCharacterization.h"
-#include "src/core/SkSpan.h"
 
 class DDLPromiseImageHelper;
 class PromiseImageCallbackContext;

tools/fonts/TestSVGTypeface.h

@@ -15,6 +15,7 @@
 #include "include/core/SkRect.h"
 #include "include/core/SkRefCnt.h"
 #include "include/core/SkScalar.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkStream.h"
 #include "include/core/SkString.h"
 #include "include/core/SkTypeface.h"
@@ -23,7 +24,6 @@
 #include "include/private/SkMutex.h"
 #include "include/private/SkTArray.h"
 #include "include/private/SkTHash.h"
-#include "src/core/SkSpan.h"
 
 #include <memory>
 

tools/fonts/create_test_font.cpp

@@ -13,12 +13,12 @@
 #include "include/core/SkFontMetrics.h"
 #include "include/core/SkFontStyle.h"
 #include "include/core/SkPath.h"
+#include "include/core/SkSpan.h"
 #include "include/core/SkStream.h"
 #include "include/core/SkTypeface.h"
 #include "include/private/SkTArray.h"
 #include "src/core/SkOSFile.h"
 #include "src/core/SkPathPriv.h"
-#include "src/core/SkSpan.h"
 #include "src/utils/SkOSPath.h"
 #include "src/utils/SkUTF.h"