AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't write instance locations for unused resolve levels

Browse Source 
This is a minor optimization for GrTessellatePathOp.cpp.

Bug: skia:10419
Change-Id: Ie9173f0827981aa254075820bee862f13a0ea333
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298902
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This commit is contained in:
Chris Dalton 2020-06-25 07:04:33 -06:00 committed by Skia Commit-Bot
parent 768adaa3c2
commit a6858aed83
1 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/gpu/tessellate/GrTessellatePathOp.cpp
View File

@ -325,12 +325,15 @@ void GrTessellatePathOp::prepareIndirectOuterCubicsAndTriangles(
runningInstanceCount = numTrianglesAtBeginningOfData;
}
for (int resolveLevel = 1; resolveLevel <= kMaxResolveLevel; ++resolveLevel) {
instanceLocations[resolveLevel] = cubicData + runningInstanceCount * 4;
if (int instanceCountAtCurrLevel = resolveLevelCounter[resolveLevel]) {
indirectData[indirectIdx++] = GrMiddleOutCubicShader::MakeDrawCubicsIndirectCmd(
resolveLevel, instanceCountAtCurrLevel, baseInstance + runningInstanceCount);
runningInstanceCount += instanceCountAtCurrLevel;
int instanceCountAtCurrLevel = resolveLevelCounter[resolveLevel];
if (!instanceCountAtCurrLevel) {
SkDEBUGCODE(instanceLocations[resolveLevel] = nullptr;)
continue;
}
instanceLocations[resolveLevel] = cubicData + runningInstanceCount * 4;
indirectData[indirectIdx++] = GrMiddleOutCubicShader::MakeDrawCubicsIndirectCmd(
resolveLevel, instanceCountAtCurrLevel, baseInstance + runningInstanceCount);
runningInstanceCount += instanceCountAtCurrLevel;
}
#ifdef SK_DEBUG
@ -340,10 +343,18 @@ void GrTessellatePathOp::prepareIndirectOuterCubicsAndTriangles(
SkASSERT(fIndirectDrawCount > 0);
SkPoint* endLocations[kMaxResolveLevel + 1];
memcpy(endLocations, instanceLocations + 1, kMaxResolveLevel * sizeof(SkPoint*));
int lastResolveLevel = 0;
for (int resolveLevel = 1; resolveLevel <= kMaxResolveLevel; ++resolveLevel) {
if (!instanceLocations[resolveLevel]) {
endLocations[resolveLevel] = nullptr;
continue;
}
endLocations[lastResolveLevel] = instanceLocations[resolveLevel];
lastResolveLevel = resolveLevel;
}
int totalInstanceCount = numTrianglesAtBeginningOfData +
resolveLevelCounter.totalCubicInstanceCount();
endLocations[kMaxResolveLevel] = cubicData + totalInstanceCount * 4;
endLocations[lastResolveLevel] = cubicData + totalInstanceCount * 4;
#endif
fCubicVertexCount = numTrianglesAtBeginningOfData * 4;