AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove a slop term from the stroke tessellation shader

Browse Source 
This was meant as a workaround for cusps on a flat line, but this
problem has been solved more robustly now.

Bug: skia:10419
Change-Id: I88625b398b8d8517ded8985c164d0e00e0c0fb79
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337948
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This commit is contained in:
Chris Dalton 2020-11-23 20:29:51 -07:00 committed by Skia Commit-Bot
parent 246fcc3895
commit a6e0d83899
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/gpu/tessellate/GrStrokeTessellateShader.cpp
View File

@ -620,9 +620,7 @@ SkString GrStrokeTessellateShader::getTessEvaluationShaderGLSL(
maxRotation = min(maxRotation, kPI);
// Is rotation <= maxRotation? (i.e., is the number of complete radial segments
// behind testT, + testParametricID <= localEdgeID?)
// NOTE: We bias cos(maxRotation) downward for fp32 error. Otherwise a flat section
// following a 180 degree turn might not render properly.
if (cosRotation >= cos(maxRotation) - 1e-5) {
if (cosRotation >= cos(maxRotation)) {
// testParametricID is on or before the localEdgeID. Keep it!
lastParametricEdgeID = testParametricID;
}