From a78ef795b032680c1d0141ae2b31dc05a74c1096 Mon Sep 17 00:00:00 2001 From: mtklein Date: Mon, 2 Jun 2014 16:40:06 -0700 Subject: [PATCH] Tweak TSAN suppressions. BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/312613002 --- tools/tsan.supp | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/tsan.supp b/tools/tsan.supp index aab8211cec..c997058db2 100644 --- a/tools/tsan.supp +++ b/tools/tsan.supp @@ -6,15 +6,26 @@ race:third_party/externals/libwebp # skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers. -# We don't always get swrast_dri.so in the stack or we'd use that. -race:SkGLContextHelper::init +# Having trouble getting this suppression to match. +# We've tried: race:swrast_dri.so +# race:SkGLContextHelper::init +# Maybe because it's diagnosed as a use-after-free, not as a race? +race:SkGLContextHelper # Threadsafe, should be ported to SkLazyPtr. race:SkFontHost_FreeType # Not threadsafe, should be fixed. -race:SkFontHost_fontconfig_ref_global +race:RefFCI race:SkString::RefRec # Not threadsafe, should be deleted. race:SkPDF + +# Should be these can be removed once TSAN learns sk_acquire_load / sk_release_store. +race:SkOnce +race:SkRefCntBase + +# This is SkLazyPtr. Also can be cleaned up when TSAN learns sk_acquire_load / sk_release_store. +race:sk_acquire_load +race:__tsan_atomic64_compare_exchange_val