Try TSAN blacklist for SkGLContextHelper::init.

Submitting to test this; this particular problem only happens on the bot.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309823004
This commit is contained in:
mtklein 2014-06-02 19:11:06 -07:00 committed by Commit bot
parent cf44feb0e1
commit ab2ec19b97
3 changed files with 12 additions and 8 deletions

View File

@ -413,7 +413,7 @@
'conditions' : [
[ 'skia_sanitizer == "thread"', {
'defines': [ 'DYNAMIC_ANNOTATIONS_ENABLED=1' ],
'cflags': [ '-fPIC' ],
'cflags': [ '-fPIC', '-fsanitize-blacklist=>!(pwd)/../tools/tsan.blacklist' ],
'target_conditions': [
[ '_type == "executable"', {
'cflags': [ '-fPIE' ],

11
tools/tsan.blacklist Normal file
View File

@ -0,0 +1,11 @@
# Blacklist (compile time suppressions) for TSAN.
#
# CAREFUL! Comments must go on their own line or your suppressions will silently fail.
# skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers.
# Having trouble getting this suppression to match.
# We've tried: race:swrast_dri.so
# race:SkGLContextHelper::init
# race:SkGLContextHelper
# So now we'll try a compile time blacklist. We'll use a file blacklist to nuke it from orbit.
file:SkGLContextHelper.cpp

View File

@ -5,13 +5,6 @@
# WebP races (harmlessly) choosing function pointers for SIMD versions of some of its functions.
race:third_party/externals/libwebp
# skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers.
# Having trouble getting this suppression to match.
# We've tried: race:swrast_dri.so
# race:SkGLContextHelper::init
# Maybe because it's diagnosed as a use-after-free, not as a race?
race:SkGLContextHelper
# Threadsafe, should be ported to SkLazyPtr.
race:SkFontHost_FreeType