AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

add virtual destructor for SkExample to fix build error.

Browse Source 
The original SkExample have virtual function draw(), but have no virtual destructor. This may lead to memory leak when free the instance of derived class of SkExample. The latest skia code show error when build SkiaExamples by "ninja -C out/Release SkiaExamples":
error: ‘class SkExample’ has virtual functions and accessible non-virtual destructor.

R=caryclark@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/98463013

git-svn-id: http://skia.googlecode.com/svn/trunk@12728 2bbb7eff-a529-9590-31e7-b0007b416f81
This commit is contained in:
commit-bot@chromium.org 2013-12-17 23:37:38 +00:00
parent 658e1b38b9
commit b09bfcb7b1
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
experimental/SkiaExamples/SkExample.h
View File

@ -23,6 +23,8 @@ class SkExample : public SkNoncopyable {
public:
SkExample(SkExampleWindow* window) : fWindow(window) {}
virtual ~SkExample() {}
// Your class should override this method to do its thing.
virtual void draw(SkCanvas* canvas) = 0;