From b15e6061c69995530b310f4ca12354ff250071e5 Mon Sep 17 00:00:00 2001 From: "borenet@google.com" Date: Mon, 11 Feb 2013 18:42:43 +0000 Subject: [PATCH] Turn off per-iteration tile time reporting It's overloading the bench graph generator. Review URL: https://codereview.appspot.com/7300088 git-svn-id: http://skia.googlecode.com/svn/trunk@7691 2bbb7eff-a529-9590-31e7-b0007b416f81 --- tools/PictureBenchmark.cpp | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/PictureBenchmark.cpp b/tools/PictureBenchmark.cpp index 7490a89d5c..b47cf961df 100644 --- a/tools/PictureBenchmark.cpp +++ b/tools/PictureBenchmark.cpp @@ -109,10 +109,10 @@ void PictureBenchmark::run(SkPicture* pict) { // seems to cause problems (i.e., INVALID_OPERATIONs) on several // platforms. To work around this, we disable the gpu timer on the // long running timer. - SkAutoTDelete longRunningTimer(this->setupTimer(false)); + SkAutoTDelete longRunningTimer(this->setupTimer()); TimerData longRunningTimerData(tiledRenderer->getPerIterTimeFormat(), tiledRenderer->getNormalTimeFormat()); - SkAutoTDelete perTileTimer(this->setupTimer()); + SkAutoTDelete perTileTimer(this->setupTimer(false)); TimerData perTileTimerData(tiledRenderer->getPerIterTimeFormat(), tiledRenderer->getNormalTimeFormat()); longRunningTimer->start(); @@ -137,7 +137,14 @@ void PictureBenchmark::run(SkPicture* pict) { fShowTruncatedCpuTime, usingGpu && fShowGpuTime); result.append("\n"); + +// TODO(borenet): Turn off per-iteration tile time reporting for now. Avoiding logging the time +// for every iteration for each tile cuts down on data file size by a significant amount. Re-enable +// this once we're loading the bench data directly into a data store and are no longer generating +// SVG graphs. +#if 0 this->logProgress(result.c_str()); +#endif configName.append(" "); SkString longRunningResult = longRunningTimerData.getResult(false, false, fRepeats,